Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Feb 18, 2025

Description

Every version bump in prettier has a chance to change the desired output and thus break our linting. This PR changes it back to a specific pinned version instead of letting npm and semver take over.

Specifically a recent change in 3.5.0 was a "breaking" change for us and changed the desired format of a css file we haven't touched in a a while. It looks like @jjhembd addressed this in 1c892c8 so merging main will work but branches may be "outdated" and break in CI.

We should keep the prettier version updated so we don't have to do as many big refactors like #12206 but it should be intentional instead of randomly when people run npm install or when CI installs a different version than people have locally. I did check and pinning the version still has it show up in npm outdated so the release process should still catch it.

Issue number and link

no issue

Testing plan

  • rm -rf node_modules
  • npm install
  • npm run prettier-check should pass

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace added the dependencies Relating to our package dependencies label Feb 18, 2025
@jjspace jjspace requested a review from ggetz February 18, 2025 19:47
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Feb 20, 2025

Thanks @jjspace!

@ggetz ggetz added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 2b8546e Feb 20, 2025
10 checks passed
@ggetz ggetz deleted the pin-prettier branch February 20, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relating to our package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants