Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Xcode 14 and Swift 5.7 compiler error#4874

Closed
dangthaison91 wants to merge 1 commit into
ChartsOrg:masterfrom
dangthaison91:master-xcode-14
Closed

Fix Xcode 14 and Swift 5.7 compiler error#4874
dangthaison91 wants to merge 1 commit into
ChartsOrg:masterfrom
dangthaison91:master-xcode-14

Conversation

@dangthaison91

Copy link
Copy Markdown

#4823 (comment)

Issue Link 🔗

Fix compilation error with Xcode 14 and Swift 5.7
#4863 #4870 #4838 #4835

Goals ⚽

Implementation Details 🚧

This PR simply collect other fixes by several developers into one PR:

Testing Details 🔍

@dingtianran

Copy link
Copy Markdown

I can confirm this patch PR works for xcode 14 beta 3&4

Comment thread Source/Charts/Animation/ChartAnimationEasing.swift Outdated
Comment thread Source/Charts/Renderers/CandleStickChartRenderer.swift Outdated
Joe-BOD pushed a commit to beachbodydigital/Charts that referenced this pull request Aug 2, 2022
* Update for the two fixes in PR now for Charts
* Swift 5.7 - ChartsOrg#4874
* XAxis beyond Chart Dataset - ChartsOrg#4839
@crazymanish

Copy link
Copy Markdown

A friendly ping to @pmairoldi to include this PR in the upcoming release! 🙏

@alanzeino

Copy link
Copy Markdown

In case anyone is wondering, beta 5 will likely be very similar to the 14.0 GM or public version, so this (or #4881) would be ready to land or use in your local fork of Charts.

@waterskier2007

waterskier2007 commented Aug 23, 2022

Copy link
Copy Markdown

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

@iDevPro

iDevPro commented Aug 23, 2022

Copy link
Copy Markdown

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

Which crashes ? May you show gist ?

@adityarajpt

Copy link
Copy Markdown

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

@waterskier2007 I tried on 14.5, I don't see any crash so far

@werkaflute

Copy link
Copy Markdown

On XCode 14.6 Beta I have errors :/

@pmairoldi pmairoldi self-assigned this Aug 27, 2022
@pmairoldi

Copy link
Copy Markdown
Collaborator

Everything from this PR has been merged from other PRs. Thanks contributing!

@pmairoldi pmairoldi closed this Aug 28, 2022
@nkark

nkark commented Aug 30, 2022

Copy link
Copy Markdown

@pmairoldi @danielgindi When will there be a new release or tag with all the changes in master? Specifically the Xcode 14 support

@pmairoldi

Copy link
Copy Markdown
Collaborator

When Xcode 14 gm is released

@alanzeino

Copy link
Copy Markdown

@pmairoldi @danielgindi When will there be a new release or tag with all the changes in master? Specifically the Xcode 14 support

change your package manager to point to the git commit and you don't need to wait for a new release or tag

@PorterHoskins

Copy link
Copy Markdown

@danielgindi Is there a plan to change the package name so we can use Apple's Charting library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.