Fix Xcode 14 compile error#4
Merged
Merged
Conversation
joeboyscout04
approved these changes
Aug 25, 2022
|
|
||
| for case let set as PieChartDataSetProtocol in pieData where | ||
| set.isVisible && set.entryCount > 0 | ||
| for case let dataSet as PieChartDataSetProtocol in pieData where |
There was a problem hiding this comment.
Some inconsistency if the as ChartData) cast is necessary or not. We have it for Candle and Radar but not for Pie chart?
Author
There was a problem hiding this comment.
@joeboyscout04 This commit was cherry-picked from a different user, so i would rather keep it as is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing compiler errors for xcode 14, since it seems that ChartsOrg#4874 is stale, while xcode 14 and iOS 16 are around the corner.
Thanks to dangthaison91