Merged
Conversation
birojnayak
commented
Mar 13, 2025
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. --> | ||
| <Project> | ||
|
|
||
| <!-- See https://github.com/dotnet/arcade/blob/dbb4142ebc34d0a4b9f26136f86065c037dc4b80/src/Microsoft.DotNet.Arcade.Sdk/tools/StrongName.targets#L33-L37 for where this was copied from --> |
Collaborator
Author
There was a problem hiding this comment.
here is the attribution from where we referenced
Collaborator
There was a problem hiding this comment.
can you add that for the props file?
twsouthwick
approved these changes
Mar 14, 2025
Collaborator
twsouthwick
left a comment
There was a problem hiding this comment.
A couple additional changes, but then LGTM
src/StrongName.props
Outdated
Comment on lines
10
to
23
| <!-- | ||
| FullAssemblySigningSupported "false" to use public signing even when full signing is possible. This is useful | ||
| in environments where full signing is non-functional or not desired. For example, | ||
| in some Linux distributions RSA+SHA1 (required for full signing) is not | ||
| functional/available, and trying to use full signing results in the runtime | ||
| throwing an exception. For more details and an example, see | ||
| https://github.com/dotnet/runtime/issues/65874. We default to full assembly | ||
| signing not being supported in source-only modes. | ||
| --> | ||
| <!-- | ||
| <PropertyGroup> | ||
| <FullAssemblySigningSupported Condition="'$(FullAssemblySigningSupported)' == '' and '$(DotNetBuildSourceOnly)' == 'true'">false</FullAssemblySigningSupported> | ||
| </PropertyGroup> | ||
| --> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <!-- | |
| FullAssemblySigningSupported "false" to use public signing even when full signing is possible. This is useful | |
| in environments where full signing is non-functional or not desired. For example, | |
| in some Linux distributions RSA+SHA1 (required for full signing) is not | |
| functional/available, and trying to use full signing results in the runtime | |
| throwing an exception. For more details and an example, see | |
| https://github.com/dotnet/runtime/issues/65874. We default to full assembly | |
| signing not being supported in source-only modes. | |
| --> | |
| <!-- | |
| <PropertyGroup> | |
| <FullAssemblySigningSupported Condition="'$(FullAssemblySigningSupported)' == '' and '$(DotNetBuildSourceOnly)' == 'true'">false</FullAssemblySigningSupported> | |
| </PropertyGroup> | |
| --> |
why keep this?
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. --> | ||
| <Project> | ||
|
|
||
| <!-- See https://github.com/dotnet/arcade/blob/dbb4142ebc34d0a4b9f26136f86065c037dc4b80/src/Microsoft.DotNet.Arcade.Sdk/tools/StrongName.targets#L33-L37 for where this was copied from --> |
Collaborator
There was a problem hiding this comment.
can you add that for the props file?
e92be19 to
abd1a81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.