Preview #525
Merged
Preview #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Preview method on Experiment in SmartSim. This method allows users to view the experiment name, path, and launcher of their created experiment before the launch of the experiment. This commit is a subcomponent of the entire Preview method. [ committed by @juliaputko ] [ reviewed by @ankona @al-rigazzi ]
Add Orchestrator preview into the Preview method on Experiment in SmartSim. This method allows users to view the properties of a created Orchestrator before the launch of an experiment. This commit is a subcomponent of the entire Preview method. [ committed by @juliaputko ] [ reviewed by @ankona @al-rigazzi ]
Add Model preview into the Preview method on Experiment in SmartSim. This method allows users to view the properties of a created Model before the launch of an experiment. This commit is a subcomponent of the entire Preview method. [ committed by @juliaputko ] [ reviewed by @ankona ]
Add Ensemble preview into the Preview method on Experiment in SmartSim. This method allows users to view the properties of a created Ensemble before the launch of an experiment. This commit is a subcomponent of the entire Preview method. [ committed by @juliaputko ] [ reviewed by @ankona ]
Add Active Infrastructure preview into the Preview method on Experiment in SmartSim. This method allows users to view the properties of active infrastructure. This commit is a subcomponent of the entire Preview method. [ committed by @juliaputko ] [ reviewed by @ankona ]
Correct spacing in templates when rendering preview. Remove unsupported test. [ committed by @juliaputko ]
Fixed spacing in templates, rewrote and added tests for filters, fixed and added tests for returning active orchestrators for preview, changed how active_db_jobs are previewed. [ committed by @juliaputko ] [ reviewed by @ankona ]
) Add Run Commands and Run arguments to entity previews. [ committed by @juliaputko ] [ reviewed by @ankona ]
Add verbosity parameters and tests to the preview method. Refactor of templates to separate verbosity levels. [ committed by @juliaputko ] [ reviewed by @ankona ]
Fixing bugs created after merging verbosity levels changes [ committed by @juliaputko ]
Most recent updates to templates
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #525 +/- ##
===========================================
- Coverage 77.77% 71.14% -6.63%
===========================================
Files 66 67 +1
Lines 4571 4637 +66
===========================================
- Hits 3555 3299 -256
- Misses 1016 1338 +322
|
mellis13
reviewed
Mar 19, 2024
Contributor
mellis13
left a comment
There was a problem hiding this comment.
Here is some initial feedback and questions. I'm still going through previewrenderer.py and the templates, but this feedback seemed orthogonal so I thought I'd leave it right away.
mellis13
reviewed
Mar 20, 2024
Contributor
mellis13
left a comment
There was a problem hiding this comment.
Just a couple of extra review comments.
ankona
reviewed
Apr 23, 2024
ankona
reviewed
Apr 23, 2024
|
|
||
|
|
||
| @pytest.fixture | ||
| def choose_host(): |
Contributor
There was a problem hiding this comment.
This is available in conftest.py already and you should be able to get rid of the duplicate declaration
ankona
reviewed
Apr 23, 2024
| return _choose_host | ||
|
|
||
|
|
||
| def add_batch_resources(wlmutils, batch_settings): |
Contributor
There was a problem hiding this comment.
This is also available in test_generic_bach.py. Let's move it to conftest.py and reuse in both test harnesses.
AlyssaCote
reviewed
Apr 24, 2024
Addressing PR comments, added documentation, fixed bugs in tests [ committed by @juliaputko ] [ reviewed by @AlyssaCote , @amandarichardsonn, @ankona ]
ankona
reviewed
May 2, 2024
ankona
reviewed
May 2, 2024
ankona
reviewed
May 2, 2024
Small index change that was missed [ committed by @juliaputko ]
Contributor
amandarichardsonn
left a comment
There was a problem hiding this comment.
Awesome job with the documentation! Looks fantastic, just some suggestions -> plz excuse any grammatical errors I made!
[ committed by @juliaputko ] [ reviewed by @ankona ]
[ committed by @juliaputko ]
Avoid detailed paths in templates by configuring the template loader to use output format [ committed by @ankona ] [ reviewed by @juliaputko ]
ankona
reviewed
May 6, 2024
[ committed by @juliaputko ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.