Probe trace endpoints with a valid payload of empty arrays #8414

mcculls · 2025-02-18T14:26:31Z

What Does This Do

Changes trace endpoint probing to use a valid payload of empty arrays

This was originally applied in 210fd39 but was reverted because an old test agent we were using at the time expected empty requests (whereas the real agent expects valid non-empty payloads.)

Motivation

Avoids probing real agents with invalid payloads - while this doesn't affect the probing (as it looks for any response that's not 404) it is always better to use a valid payload for probing.

Additional Notes

Probing only applies when the tracer has not been able to query the /info endpoint, as that output includes the appropriate trace endpoint to use.

We may want to consider using a HEAD request for probing in the future.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-1161

pr-commenter · 2025-02-18T15:03:56Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/probe-trace-endpoint-with-valid-body
git_commit_date	1739883510	1739888319
git_commit_sha	`a47c3ce`	`379afc3`
release_version	1.47.0-SNAPSHOT~a47c3cefc3	1.47.0-SNAPSHOT~379afc35cd

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739890750	1739890750
ci_job_id	811951969	811951969
ci_pipeline_id	56153226	56153226
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-ub1wle-f-project-304-concurrent-0-2gtlpdxv 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-ub1wle-f-project-304-concurrent-0-2gtlpdxv 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054484
Total [baseline] (8.633 s) : 0, 8632693
Agent [candidate] (1.043 s) : 0, 1042909
Total [candidate] (8.63 s) : 0, 8630194
section iast
Agent [baseline] (1.171 s) : 0, 1170750
Total [baseline] (9.267 s) : 0, 9266863
Agent [candidate] (1.169 s) : 0, 1169073
Total [candidate] (9.209 s) : 0, 9209151
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179248
Total [baseline] (9.232 s) : 0, 9231970
Agent [candidate] (1.176 s) : 0, 1176481
Total [candidate] (9.247 s) : 0, 9247202
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170100
Total [baseline] (9.219 s) : 0, 9219116
Agent [candidate] (1.177 s) : 0, 1176710
Total [candidate] (9.278 s) : 0, 9278073

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.171 s	116.266 ms (11.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	124.765 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.17 s	115.616 ms (11.0%)
Total	tracing	8.633 s	-
Total	iast	9.267 s	634.17 ms (7.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.232 s	599.278 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.219 s	586.423 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.169 s	126.165 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	133.573 ms (12.8%)
Agent	iast_TELEMETRY_OFF	1.177 s	133.801 ms (12.8%)
Total	tracing	8.63 s	-
Total	iast	9.209 s	578.958 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.247 s	617.008 ms (7.1%)
Total	iast_TELEMETRY_OFF	9.278 s	647.879 ms (7.5%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.054 ms) : 0, 726054
BytebuddyAgent [candidate] (717.616 ms) : 0, 717616
GlobalTracer [baseline] (240.749 ms) : 0, 240749
GlobalTracer [candidate] (239.663 ms) : 0, 239663
AppSec [baseline] (55.876 ms) : 0, 55876
AppSec [candidate] (55.588 ms) : 0, 55588
Remote Config [baseline] (699.461 µs) : 0, 699
Remote Config [candidate] (691.377 µs) : 0, 691
Telemetry [baseline] (15.707 ms) : 0, 15707
Telemetry [candidate] (14.199 ms) : 0, 14199
section iast
BytebuddyAgent [baseline] (835.586 ms) : 0, 835586
BytebuddyAgent [candidate] (834.736 ms) : 0, 834736
GlobalTracer [baseline] (230.776 ms) : 0, 230776
GlobalTracer [candidate] (230.264 ms) : 0, 230264
IAST [baseline] (22.859 ms) : 0, 22859
IAST [candidate] (22.798 ms) : 0, 22798
AppSec [baseline] (57.091 ms) : 0, 57091
AppSec [candidate] (56.926 ms) : 0, 56926
Remote Config [baseline] (610.05 µs) : 0, 610
Remote Config [candidate] (599.834 µs) : 0, 600
Telemetry [baseline] (8.623 ms) : 0, 8623
Telemetry [candidate] (8.597 ms) : 0, 8597
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.614 ms) : 0, 841614
BytebuddyAgent [candidate] (838.668 ms) : 0, 838668
GlobalTracer [baseline] (231.351 ms) : 0, 231351
GlobalTracer [candidate] (232.034 ms) : 0, 232034
IAST [baseline] (23.401 ms) : 0, 23401
IAST [candidate] (23.179 ms) : 0, 23179
AppSec [baseline] (58.005 ms) : 0, 58005
AppSec [candidate] (57.776 ms) : 0, 57776
Remote Config [baseline] (635.795 µs) : 0, 636
Remote Config [candidate] (620.397 µs) : 0, 620
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (8.915 ms) : 0, 8915
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.223 ms) : 0, 835223
BytebuddyAgent [candidate] (840.136 ms) : 0, 840136
GlobalTracer [baseline] (231.266 ms) : 0, 231266
GlobalTracer [candidate] (232.001 ms) : 0, 232001
IAST [baseline] (27.816 ms) : 0, 27816
IAST [candidate] (27.299 ms) : 0, 27299
AppSec [baseline] (51.367 ms) : 0, 51367
AppSec [candidate] (52.58 ms) : 0, 52580
Remote Config [baseline] (613.152 µs) : 0, 613
Remote Config [candidate] (623.563 µs) : 0, 624
Telemetry [baseline] (8.621 ms) : 0, 8621
Telemetry [candidate] (8.658 ms) : 0, 8658

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1037949
Total [baseline] (10.431 s) : 0, 10430515
Agent [candidate] (1.04 s) : 0, 1039523
Total [candidate] (10.455 s) : 0, 10454659
section appsec
Agent [baseline] (1.182 s) : 0, 1181656
Total [baseline] (10.728 s) : 0, 10727511
Agent [candidate] (1.184 s) : 0, 1184072
Total [candidate] (10.71 s) : 0, 10710339
section iast
Agent [baseline] (1.185 s) : 0, 1184626
Total [baseline] (10.955 s) : 0, 10955314
Agent [candidate] (1.171 s) : 0, 1171417
Total [candidate] (10.984 s) : 0, 10983618
section profiling
Agent [baseline] (1.261 s) : 0, 1261446
Total [baseline] (10.85 s) : 0, 10849992
Agent [candidate] (1.26 s) : 0, 1259542
Total [candidate] (10.84 s) : 0, 10839745

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	appsec	1.182 s	143.706 ms (13.8%)
Agent	iast	1.185 s	146.677 ms (14.1%)
Agent	profiling	1.261 s	223.496 ms (21.5%)
Total	tracing	10.431 s	-
Total	appsec	10.728 s	296.997 ms (2.8%)
Total	iast	10.955 s	524.799 ms (5.0%)
Total	profiling	10.85 s	419.478 ms (4.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	appsec	1.184 s	144.549 ms (13.9%)
Agent	iast	1.171 s	131.894 ms (12.7%)
Agent	profiling	1.26 s	220.019 ms (21.2%)
Total	tracing	10.455 s	-
Total	appsec	10.71 s	255.679 ms (2.4%)
Total	iast	10.984 s	528.959 ms (5.1%)
Total	profiling	10.84 s	385.086 ms (3.7%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.287 ms) : 0, 716287
BytebuddyAgent [candidate] (716.405 ms) : 0, 716405
GlobalTracer [baseline] (239.206 ms) : 0, 239206
GlobalTracer [candidate] (239.191 ms) : 0, 239191
AppSec [baseline] (55.291 ms) : 0, 55291
AppSec [candidate] (55.284 ms) : 0, 55284
Remote Config [baseline] (694.189 µs) : 0, 694
Remote Config [candidate] (686.464 µs) : 0, 686
Telemetry [baseline] (11.239 ms) : 0, 11239
Telemetry [candidate] (12.752 ms) : 0, 12752
section appsec
BytebuddyAgent [baseline] (734.001 ms) : 0, 734001
BytebuddyAgent [candidate] (735.192 ms) : 0, 735192
GlobalTracer [baseline] (236.04 ms) : 0, 236040
GlobalTracer [candidate] (236.996 ms) : 0, 236996
IAST [baseline] (21.43 ms) : 0, 21430
IAST [candidate] (21.433 ms) : 0, 21433
AppSec [baseline] (176.43 ms) : 0, 176430
AppSec [candidate] (177.05 ms) : 0, 177050
Remote Config [baseline] (657.834 µs) : 0, 658
Remote Config [candidate] (667.799 µs) : 0, 668
Telemetry [baseline] (8.599 ms) : 0, 8599
Telemetry [candidate] (8.277 ms) : 0, 8277
section iast
BytebuddyAgent [baseline] (846.833 ms) : 0, 846833
BytebuddyAgent [candidate] (836.351 ms) : 0, 836351
GlobalTracer [baseline] (232.278 ms) : 0, 232278
GlobalTracer [candidate] (230.492 ms) : 0, 230492
IAST [baseline] (23.2 ms) : 0, 23200
IAST [candidate] (22.515 ms) : 0, 22515
AppSec [baseline] (57.377 ms) : 0, 57377
AppSec [candidate] (57.453 ms) : 0, 57453
Remote Config [baseline] (624.972 µs) : 0, 625
Remote Config [candidate] (607.451 µs) : 0, 607
Telemetry [baseline] (8.882 ms) : 0, 8882
Telemetry [candidate] (8.653 ms) : 0, 8653
section profiling
BytebuddyAgent [baseline] (707.94 ms) : 0, 707940
BytebuddyAgent [candidate] (706.78 ms) : 0, 706780
GlobalTracer [baseline] (349.511 ms) : 0, 349511
GlobalTracer [candidate] (350.366 ms) : 0, 350366
AppSec [baseline] (55.673 ms) : 0, 55673
AppSec [candidate] (54.579 ms) : 0, 54579
Remote Config [baseline] (671.267 µs) : 0, 671
Remote Config [candidate] (674.714 µs) : 0, 675
Telemetry [baseline] (8.95 ms) : 0, 8950
Telemetry [candidate] (8.969 ms) : 0, 8969
ProfilingAgent [baseline] (96.461 ms) : 0, 96461
ProfilingAgent [candidate] (95.87 ms) : 0, 95870
Profiling [baseline] (96.485 ms) : 0, 96485
Profiling [candidate] (95.894 ms) : 0, 95894

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-18T14:31:14	2025-02-18T14:38:20
git_branch	master	mcculls/probe-trace-endpoint-with-valid-body
git_commit_date	1739883510	1739888319
git_commit_sha	`a47c3ce`	`379afc3`
release_version	1.47.0-SNAPSHOT~a47c3cefc3	1.47.0-SNAPSHOT~379afc35cd
start_time	2025-02-18T14:31:00	2025-02-18T14:38:06

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739889860	1739889860
ci_job_id	811951971	811951971
ci_pipeline_id	56153226	56153226
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-g-bssrbz-project-304-concurrent-0-t77mt6r3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-g-bssrbz-project-304-concurrent-0-t77mt6r3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.925 µs) : 359, 399
.   : milestone, 379,
iast (511.564 µs) : 489, 534
.   : milestone, 512,
iast_FULL (734.663 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (565.521 µs) : 543, 588
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (519.19 µs) : 496, 543
.   : milestone, 519,
iast_INACTIVE (469.03 µs) : 447, 491
.   : milestone, 469,
iast_TELEMETRY_OFF (502.878 µs) : 479, 527
.   : milestone, 503,
tracing (459.965 µs) : 438, 482
.   : milestone, 460,
section candidate
no_agent (377.819 µs) : 358, 398
.   : milestone, 378,
iast (510.561 µs) : 489, 532
.   : milestone, 511,
iast_FULL (734.962 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (563.304 µs) : 541, 586
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (522.808 µs) : 500, 546
.   : milestone, 523,
iast_INACTIVE (457.624 µs) : 437, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (508.141 µs) : 484, 532
.   : milestone, 508,
tracing (457.88 µs) : 437, 479
.   : milestone, 458,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.925 µs [358.721 µs, 399.13 µs]	-
iast	511.564 µs [489.007 µs, 534.12 µs]	132.639 µs (35.0%)
iast_FULL	734.663 µs [712.654 µs, 756.673 µs]	355.738 µs (93.9%)
iast_GLOBAL	565.521 µs [542.595 µs, 588.448 µs]	186.596 µs (49.2%)
iast_HARDCODED_SECRET_DISABLED	519.19 µs [495.603 µs, 542.777 µs]	140.265 µs (37.0%)
iast_INACTIVE	469.03 µs [447.115 µs, 490.946 µs]	90.105 µs (23.8%)
iast_TELEMETRY_OFF	502.878 µs [479.153 µs, 526.604 µs]	123.953 µs (32.7%)
tracing	459.965 µs [438.058 µs, 481.871 µs]	81.04 µs (21.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.819 µs [357.613 µs, 398.026 µs]	-
iast	510.561 µs [488.662 µs, 532.46 µs]	132.742 µs (35.1%)
iast_FULL	734.962 µs [713.131 µs, 756.793 µs]	357.143 µs (94.5%)
iast_GLOBAL	563.304 µs [541.062 µs, 585.547 µs]	185.485 µs (49.1%)
iast_HARDCODED_SECRET_DISABLED	522.808 µs [499.828 µs, 545.788 µs]	144.989 µs (38.4%)
iast_INACTIVE	457.624 µs [436.584 µs, 478.665 µs]	79.805 µs (21.1%)
iast_TELEMETRY_OFF	508.141 µs [484.273 µs, 532.008 µs]	130.321 µs (34.5%)
tracing	457.88 µs [437.106 µs, 478.655 µs]	80.061 µs (21.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1379
.   : milestone, 1359,
appsec (1.757 ms) : 1734, 1781
.   : milestone, 1757,
appsec_no_iast (1.76 ms) : 1735, 1786
.   : milestone, 1760,
iast (1.534 ms) : 1510, 1558
.   : milestone, 1534,
profiling (1.521 ms) : 1495, 1546
.   : milestone, 1521,
tracing (1.497 ms) : 1473, 1521
.   : milestone, 1497,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.771 ms) : 1747, 1794
.   : milestone, 1771,
appsec_no_iast (1.764 ms) : 1740, 1789
.   : milestone, 1764,
iast (1.527 ms) : 1503, 1551
.   : milestone, 1527,
profiling (1.525 ms) : 1502, 1549
.   : milestone, 1525,
tracing (1.511 ms) : 1487, 1535
.   : milestone, 1511,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.339 ms, 1.379 ms]	-
appsec	1.757 ms [1.734 ms, 1.781 ms]	398.415 µs (29.3%)
appsec_no_iast	1.76 ms [1.735 ms, 1.786 ms]	401.442 µs (29.5%)
iast	1.534 ms [1.51 ms, 1.558 ms]	174.984 µs (12.9%)
profiling	1.521 ms [1.495 ms, 1.546 ms]	161.927 µs (11.9%)
tracing	1.497 ms [1.473 ms, 1.521 ms]	138.22 µs (10.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.362 ms [1.343 ms, 1.382 ms]	-
appsec	1.771 ms [1.747 ms, 1.794 ms]	408.343 µs (30.0%)
appsec_no_iast	1.764 ms [1.74 ms, 1.789 ms]	402.216 µs (29.5%)
iast	1.527 ms [1.503 ms, 1.551 ms]	164.807 µs (12.1%)
profiling	1.525 ms [1.502 ms, 1.549 ms]	163.051 µs (12.0%)
tracing	1.511 ms [1.487 ms, 1.535 ms]	148.398 µs (10.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/probe-trace-endpoint-with-valid-body
git_commit_date	1739883510	1739888319
git_commit_sha	`a47c3ce`	`379afc3`
release_version	1.47.0-SNAPSHOT~a47c3cefc3	1.47.0-SNAPSHOT~379afc35cd

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739890300	1739890300
ci_job_id	811951973	811951973
ci_pipeline_id	56153226	56153226
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-lbteb8uf-project-304-concurrent-0-io6565d7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-lbteb8uf-project-304-concurrent-0-io6565d7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.945 s) : 14945000, 14945000
.   : milestone, 14945000,
appsec (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
iast (18.643 s) : 18643000, 18643000
.   : milestone, 18643000,
iast_GLOBAL (17.78 s) : 17780000, 17780000
.   : milestone, 17780000,
profiling (15.256 s) : 15256000, 15256000
.   : milestone, 15256000,
tracing (14.849 s) : 14849000, 14849000
.   : milestone, 14849000,
section candidate
no_agent (15.638 s) : 15638000, 15638000
.   : milestone, 15638000,
appsec (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
iast (18.68 s) : 18680000, 18680000
.   : milestone, 18680000,
iast_GLOBAL (18.11 s) : 18110000, 18110000
.   : milestone, 18110000,
profiling (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
tracing (15.129 s) : 15129000, 15129000
.   : milestone, 15129000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.945 s [14.945 s, 14.945 s]	-
appsec	15.114 s [15.114 s, 15.114 s]	169.0 ms (1.1%)
iast	18.643 s [18.643 s, 18.643 s]	3.698 s (24.7%)
iast_GLOBAL	17.78 s [17.78 s, 17.78 s]	2.835 s (19.0%)
profiling	15.256 s [15.256 s, 15.256 s]	311.0 ms (2.1%)
tracing	14.849 s [14.849 s, 14.849 s]	-96.0 ms (-0.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.638 s [15.638 s, 15.638 s]	-
appsec	15.002 s [15.002 s, 15.002 s]	-636.0 ms (-4.1%)
iast	18.68 s [18.68 s, 18.68 s]	3.042 s (19.5%)
iast_GLOBAL	18.11 s [18.11 s, 18.11 s]	2.472 s (15.8%)
profiling	15.009 s [15.009 s, 15.009 s]	-629.0 ms (-4.0%)
tracing	15.129 s [15.129 s, 15.129 s]	-509.0 ms (-3.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~379afc35cd, baseline=1.47.0-SNAPSHOT~a47c3cefc3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.371 ms) : 2328, 2415
.   : milestone, 2371,
iast (2.116 ms) : 2061, 2172
.   : milestone, 2116,
iast_GLOBAL (2.158 ms) : 2102, 2213
.   : milestone, 2158,
profiling (1.984 ms) : 1939, 2029
.   : milestone, 1984,
tracing (1.961 ms) : 1918, 2004
.   : milestone, 1961,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.369 ms) : 2326, 2413
.   : milestone, 2369,
iast (2.122 ms) : 2066, 2177
.   : milestone, 2122,
iast_GLOBAL (2.155 ms) : 2100, 2211
.   : milestone, 2155,
profiling (1.97 ms) : 1927, 2014
.   : milestone, 1970,
tracing (1.95 ms) : 1908, 1992
.   : milestone, 1950,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.371 ms [2.328 ms, 2.415 ms]	897.272 µs (60.9%)
iast	2.116 ms [2.061 ms, 2.172 ms]	642.342 µs (43.6%)
iast_GLOBAL	2.158 ms [2.102 ms, 2.213 ms]	683.673 µs (46.4%)
profiling	1.984 ms [1.939 ms, 2.029 ms]	510.033 µs (34.6%)
tracing	1.961 ms [1.918 ms, 2.004 ms]	487.078 µs (33.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.369 ms [2.326 ms, 2.413 ms]	895.738 µs (60.8%)
iast	2.122 ms [2.066 ms, 2.177 ms]	648.224 µs (44.0%)
iast_GLOBAL	2.155 ms [2.1 ms, 2.211 ms]	681.556 µs (46.3%)
profiling	1.97 ms [1.927 ms, 2.014 ms]	496.835 µs (33.7%)
tracing	1.95 ms [1.908 ms, 1.992 ms]	476.368 µs (32.3%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

Probe trace endpoints with a valid payload of empty arrays

379afc3

mcculls added comp: core Tracer core type: task labels Feb 18, 2025

mcculls marked this pull request as ready for review February 18, 2025 15:06

mcculls requested a review from a team as a code owner February 18, 2025 15:06

mcculls requested review from dougqh and bantonsson February 18, 2025 15:06

bantonsson approved these changes Feb 18, 2025

View reviewed changes

mcculls merged commit 19c561e into master Feb 18, 2025
206 of 208 checks passed

mcculls deleted the mcculls/probe-trace-endpoint-with-valid-body branch February 18, 2025 16:01

github-actions bot added this to the 1.47.0 milestone Feb 18, 2025

manuel-alvarez-alvarez added the type: enhancement label Mar 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Probe trace endpoints with a valid payload of empty arrays #8414

Probe trace endpoints with a valid payload of empty arrays #8414

mcculls commented Feb 18, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Feb 18, 2025

Probe trace endpoints with a valid payload of empty arrays #8414

Probe trace endpoints with a valid payload of empty arrays #8414

Conversation

mcculls commented Feb 18, 2025 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Feb 18, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

mcculls commented Feb 18, 2025 •

edited by jira bot

Loading