-
Notifications
You must be signed in to change notification settings - Fork 301
Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit #8465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit #8465
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040981
Total [baseline] (8.642 s) : 0, 8642326
Agent [candidate] (1.047 s) : 0, 1047126
Total [candidate] (8.672 s) : 0, 8671876
section iast
Agent [baseline] (1.17 s) : 0, 1170350
Total [baseline] (9.244 s) : 0, 9244015
Agent [candidate] (1.171 s) : 0, 1170906
Total [candidate] (9.254 s) : 0, 9253890
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170729
Total [baseline] (9.205 s) : 0, 9205061
Agent [candidate] (1.18 s) : 0, 1179738
Total [candidate] (9.265 s) : 0, 9264833
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172650
Total [baseline] (9.268 s) : 0, 9267500
Agent [candidate] (1.168 s) : 0, 1168277
Total [candidate] (9.261 s) : 0, 9260862
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.89 ms) : 0, 716890
BytebuddyAgent [candidate] (722.824 ms) : 0, 722824
GlobalTracer [baseline] (238.777 ms) : 0, 238777
GlobalTracer [candidate] (239.53 ms) : 0, 239530
AppSec [baseline] (55.39 ms) : 0, 55390
AppSec [candidate] (55.949 ms) : 0, 55949
Remote Config [baseline] (690.154 Β΅s) : 0, 690
Remote Config [candidate] (704.514 Β΅s) : 0, 705
Telemetry [baseline] (14.283 ms) : 0, 14283
Telemetry [candidate] (13.097 ms) : 0, 13097
section iast
BytebuddyAgent [baseline] (836.183 ms) : 0, 836183
BytebuddyAgent [candidate] (837.266 ms) : 0, 837266
GlobalTracer [baseline] (230.04 ms) : 0, 230040
GlobalTracer [candidate] (229.629 ms) : 0, 229629
IAST [baseline] (22.793 ms) : 0, 22793
IAST [candidate] (22.822 ms) : 0, 22822
AppSec [baseline] (57.016 ms) : 0, 57016
AppSec [candidate] (57.008 ms) : 0, 57008
Remote Config [baseline] (612.999 Β΅s) : 0, 613
Remote Config [candidate] (604.785 Β΅s) : 0, 605
Telemetry [baseline] (8.735 ms) : 0, 8735
Telemetry [candidate] (8.696 ms) : 0, 8696
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.304 ms) : 0, 836304
BytebuddyAgent [candidate] (843.499 ms) : 0, 843499
GlobalTracer [baseline] (230.071 ms) : 0, 230071
GlobalTracer [candidate] (231.274 ms) : 0, 231274
IAST [baseline] (22.936 ms) : 0, 22936
IAST [candidate] (23.214 ms) : 0, 23214
AppSec [baseline] (57.157 ms) : 0, 57157
AppSec [candidate] (57.245 ms) : 0, 57245
Remote Config [baseline] (610.805 Β΅s) : 0, 611
Remote Config [candidate] (614.162 Β΅s) : 0, 614
Telemetry [baseline] (8.695 ms) : 0, 8695
Telemetry [candidate] (8.808 ms) : 0, 8808
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.726 ms) : 0, 837726
BytebuddyAgent [candidate] (834.082 ms) : 0, 834082
GlobalTracer [baseline] (231.144 ms) : 0, 231144
GlobalTracer [candidate] (230.418 ms) : 0, 230418
IAST [baseline] (26.423 ms) : 0, 26423
IAST [candidate] (23.153 ms) : 0, 23153
AppSec [baseline] (53.03 ms) : 0, 53030
AppSec [candidate] (56.417 ms) : 0, 56417
Remote Config [baseline] (619.833 Β΅s) : 0, 620
Remote Config [candidate] (621.038 Β΅s) : 0, 621
Telemetry [baseline] (8.696 ms) : 0, 8696
Telemetry [candidate] (8.691 ms) : 0, 8691
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044463
Total [baseline] (10.436 s) : 0, 10436007
Agent [candidate] (1.05 s) : 0, 1050171
Total [candidate] (10.401 s) : 0, 10401317
section appsec
Agent [baseline] (1.181 s) : 0, 1181329
Total [baseline] (10.684 s) : 0, 10683864
Agent [candidate] (1.183 s) : 0, 1182718
Total [candidate] (10.76 s) : 0, 10759765
section iast
Agent [baseline] (1.172 s) : 0, 1171765
Total [baseline] (10.953 s) : 0, 10952880
Agent [candidate] (1.171 s) : 0, 1171469
Total [candidate] (10.951 s) : 0, 10950939
section profiling
Agent [baseline] (1.258 s) : 0, 1258104
Total [baseline] (10.805 s) : 0, 10805188
Agent [candidate] (1.267 s) : 0, 1267082
Total [candidate] (10.832 s) : 0, 10831809
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.336 ms) : 0, 719336
BytebuddyAgent [candidate] (723.902 ms) : 0, 723902
GlobalTracer [baseline] (239.514 ms) : 0, 239514
GlobalTracer [candidate] (242.032 ms) : 0, 242032
AppSec [baseline] (56.091 ms) : 0, 56091
AppSec [candidate] (56.203 ms) : 0, 56203
Remote Config [baseline] (699.272 Β΅s) : 0, 699
Remote Config [candidate] (705.938 Β΅s) : 0, 706
Telemetry [baseline] (13.847 ms) : 0, 13847
Telemetry [candidate] (12.301 ms) : 0, 12301
section appsec
BytebuddyAgent [baseline] (734.064 ms) : 0, 734064
BytebuddyAgent [candidate] (734.87 ms) : 0, 734870
GlobalTracer [baseline] (235.743 ms) : 0, 235743
GlobalTracer [candidate] (235.694 ms) : 0, 235694
AppSec [baseline] (176.993 ms) : 0, 176993
AppSec [candidate] (177.587 ms) : 0, 177587
Remote Config [baseline] (654.482 Β΅s) : 0, 654
Remote Config [candidate] (658.176 Β΅s) : 0, 658
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.314 ms) : 0, 8314
IAST [baseline] (21.429 ms) : 0, 21429
IAST [candidate] (21.407 ms) : 0, 21407
section iast
BytebuddyAgent [baseline] (837.528 ms) : 0, 837528
BytebuddyAgent [candidate] (836.282 ms) : 0, 836282
GlobalTracer [baseline] (230.25 ms) : 0, 230250
GlobalTracer [candidate] (230.178 ms) : 0, 230178
AppSec [baseline] (57.019 ms) : 0, 57019
AppSec [candidate] (57.578 ms) : 0, 57578
Remote Config [baseline] (603.28 Β΅s) : 0, 603
Remote Config [candidate] (610.745 Β΅s) : 0, 611
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.819 ms) : 0, 8819
IAST [baseline] (22.776 ms) : 0, 22776
IAST [candidate] (22.952 ms) : 0, 22952
section profiling
ProfilingAgent [baseline] (96.294 ms) : 0, 96294
ProfilingAgent [candidate] (96.929 ms) : 0, 96929
BytebuddyAgent [baseline] (708.2 ms) : 0, 708200
BytebuddyAgent [candidate] (713.566 ms) : 0, 713566
GlobalTracer [baseline] (348.727 ms) : 0, 348727
GlobalTracer [candidate] (351.36 ms) : 0, 351360
AppSec [baseline] (55.204 ms) : 0, 55204
AppSec [candidate] (54.778 ms) : 0, 54778
Remote Config [baseline] (658.793 Β΅s) : 0, 659
Remote Config [candidate] (662.059 Β΅s) : 0, 662
Telemetry [baseline] (8.883 ms) : 0, 8883
Telemetry [candidate] (9.086 ms) : 0, 9086
Profiling [baseline] (96.318 ms) : 0, 96318
Profiling [candidate] (96.953 ms) : 0, 96953
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section baseline
no_agent (372.7 Β΅s) : 353, 393
. : milestone, 373,
iast (505.155 Β΅s) : 483, 528
. : milestone, 505,
iast_FULL (725.711 Β΅s) : 704, 748
. : milestone, 726,
iast_GLOBAL (558.236 Β΅s) : 536, 581
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (503.204 Β΅s) : 481, 526
. : milestone, 503,
iast_INACTIVE (460.896 Β΅s) : 439, 483
. : milestone, 461,
iast_TELEMETRY_OFF (492.076 Β΅s) : 470, 514
. : milestone, 492,
tracing (446.797 Β΅s) : 426, 467
. : milestone, 447,
section candidate
no_agent (380.504 Β΅s) : 360, 401
. : milestone, 381,
iast (500.267 Β΅s) : 478, 523
. : milestone, 500,
iast_FULL (722.836 Β΅s) : 701, 745
. : milestone, 723,
iast_GLOBAL (553.298 Β΅s) : 531, 576
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (504.333 Β΅s) : 483, 526
. : milestone, 504,
iast_INACTIVE (461.772 Β΅s) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (494.79 Β΅s) : 471, 518
. : milestone, 495,
tracing (459.038 Β΅s) : 437, 481
. : milestone, 459,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1367
. : milestone, 1347,
appsec (1.741 ms) : 1718, 1764
. : milestone, 1741,
appsec_no_iast (1.737 ms) : 1713, 1761
. : milestone, 1737,
code_origins (1.668 ms) : 1635, 1701
. : milestone, 1668,
iast (1.513 ms) : 1490, 1537
. : milestone, 1513,
profiling (1.558 ms) : 1533, 1583
. : milestone, 1558,
tracing (1.495 ms) : 1471, 1520
. : milestone, 1495,
section candidate
no_agent (1.358 ms) : 1339, 1377
. : milestone, 1358,
appsec (1.72 ms) : 1696, 1744
. : milestone, 1720,
appsec_no_iast (1.722 ms) : 1697, 1747
. : milestone, 1722,
code_origins (1.679 ms) : 1646, 1711
. : milestone, 1679,
iast (1.506 ms) : 1482, 1529
. : milestone, 1506,
profiling (1.5 ms) : 1476, 1523
. : milestone, 1500,
tracing (1.482 ms) : 1456, 1508
. : milestone, 1482,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.341 ms) : 2298, 2385
. : milestone, 2341,
iast (2.108 ms) : 2053, 2163
. : milestone, 2108,
iast_GLOBAL (2.16 ms) : 2105, 2216
. : milestone, 2160,
profiling (1.976 ms) : 1932, 2020
. : milestone, 1976,
tracing (1.949 ms) : 1907, 1991
. : milestone, 1949,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.342 ms) : 2299, 2386
. : milestone, 2342,
iast (2.105 ms) : 2050, 2160
. : milestone, 2105,
iast_GLOBAL (2.159 ms) : 2103, 2214
. : milestone, 2159,
profiling (1.974 ms) : 1930, 2018
. : milestone, 1974,
tracing (1.957 ms) : 1914, 1999
. : milestone, 1957,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0ba5cb2241, baseline=1.47.0-SNAPSHOT~5328e2b1a1
dateFormat X
axisFormat %s
section baseline
no_agent (15.451 s) : 15451000, 15451000
. : milestone, 15451000,
appsec (14.941 s) : 14941000, 14941000
. : milestone, 14941000,
iast (19.13 s) : 19130000, 19130000
. : milestone, 19130000,
iast_GLOBAL (18.057 s) : 18057000, 18057000
. : milestone, 18057000,
profiling (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
tracing (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
section candidate
no_agent (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
appsec (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
iast (19.074 s) : 19074000, 19074000
. : milestone, 19074000,
iast_GLOBAL (18.372 s) : 18372000, 18372000
. : milestone, 18372000,
profiling (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
tracing (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
|
} catch (AssertionError e) { | ||
println "Expected events: $expectedEvents" // TODO remove | ||
println "Actual events: $actualEvents" // TODO remove | ||
throw new org.opentest4j.AssertionFailedError("Events mismatch", expectedEvents, actualEvents, e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a comment here to check if this is for testing purposes in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've added this to debug a failure that only happened in CI and not locally.
The thing is that when the tests are run in an IDE, the AssertionFailedError
message contains the diffs, which is very convenient for debugging, but when running in CI, the diffs are not printed.
So I'll leave these logs in place with an if (ciRun)
condition.
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - π Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#​8483](DataDog/dd-trace-java#8483) - [@​jandro996](https://github.com/jandro996)) - π Add exclusion to solve IAST weak randomness vulnerability false positives ([#​8462](DataDog/dd-trace-java#8462) - [@​jandro996](https://github.com/jandro996)) - β¨ Fix weak randomness false positive in Kafka client ([#​8408](DataDog/dd-trace-java#8408) - [@​smola](https://github.com/smola)) - β¨ Fix location for SSRF with Kong Unirest ([#​8407](DataDog/dd-trace-java#8407) - [@​smola](https://github.com/smola)) - β¨ Exclude IBM Instana from IAST ([#​8406](DataDog/dd-trace-java#8406) - [@​smola](https://github.com/smola)) - π Fix org.json iast instrumentation test for latest dependency ([#​8347](DataDog/dd-trace-java#8347) - [@​jandro996](https://github.com/jandro996)) - β¨ Configuration to Disable APM Tracing ([#​8219](DataDog/dd-trace-java#8219) - [@​jandro996](https://github.com/jandro996)) - β¨ Address cookie vulnerability cardinality issues ([#​8210](DataDog/dd-trace-java#8210) - [@​jandro996](https://github.com/jandro996)) - β¨ Email HTML Injection detection in IAST ([#​8205](DataDog/dd-trace-java#8205) - [@​sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - πβ¨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#​8376](DataDog/dd-trace-java#8376) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - πβ¨ Ensure usr.exists tag is not overridden by auto instrumentation ([#​8374](DataDog/dd-trace-java#8374) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - β¨ Update appsec metrics with event_rules_version tag ([#​8354](DataDog/dd-trace-java#8354) - [@​sezen-datadog](https://github.com/sezen-datadog)) - β¨ Update metrics: appsec.waf.requests ([#​8353](DataDog/dd-trace-java#8353) - [@​Mariovido](https://github.com/Mariovido)) - β¨ Improve ASM support in vert.x 5.0 ([#​8285](DataDog/dd-trace-java#8285) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - β¨ Update metrics: appsec.waf.updates and appsec.waf.init ([#​8280](DataDog/dd-trace-java#8280) - [@​Mariovido](https://github.com/Mariovido)) - β¨ Configuration to Disable APM Tracing ([#​8219](DataDog/dd-trace-java#8219) - [@​jandro996](https://github.com/jandro996)) ##### Build & Tooling - π Do not generate Muzzle references for primitive arrays in method body ([#​8361](DataDog/dd-trace-java#8361) - [@​amarziali](https://github.com/amarziali)) - π Improve dev env setup documentation for Windows ([#​8180](DataDog/dd-trace-java#8180) - [@​lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - β¨ Add support for skip-EFD tagging ([#​8487](DataDog/dd-trace-java#8487) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - π Fix an NPE in Gradle Android instrumentation ([#​8484](DataDog/dd-trace-java#8484) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - β¨ Consider modified tests when applying fail-fast tests ordering ([#​8474](DataDog/dd-trace-java#8474) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - β¨ Implement tests reordering for TestNG ([#​8467](DataDog/dd-trace-java#8467) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - π Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#​8465](DataDog/dd-trace-java#8465) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - π§Ή Use separate TestEventHandlers per framework in CI Vis instrumentations ([#​8451](DataDog/dd-trace-java#8451) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - β¨ Remove warning log when JUnit 4 test method cannot be retrieved ([#​8445](DataDog/dd-trace-java#8445) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - π Fix Scalatest tracing for tests that are reported asynchronously ([#​8444](DataDog/dd-trace-java#8444) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - β¨ Implement attempt to fix tests ([#​8393](DataDog/dd-trace-java#8393) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - β¨ Implement test disabling ([#​8377](DataDog/dd-trace-java#8377) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - β¨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#​8349](DataDog/dd-trace-java#8349) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - β¨ Request Test Management tests list ([#​8345](DataDog/dd-trace-java#8345) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - β¨ Receive test management settings from CIVis settings request ([#​8331](DataDog/dd-trace-java#8331) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - β¨ Implement quarantined tests tagging ([#​8326](DataDog/dd-trace-java#8326) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - β¨ Implement tests quarantining ([#​8320](DataDog/dd-trace-java#8320) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - β¨ Add tag to specify if the user is setting DD_SERVICE ([#​8318](DataDog/dd-trace-java#8318) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - β¨ Only fork jps when required ([#​8419](DataDog/dd-trace-java#8419) - [@​mcculls](https://github.com/mcculls)) - π Use Java home of the crashed process to launch crash uploader ([#​8348](DataDog/dd-trace-java#8348) - [@​jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - π Fix error happening when sqs message attributes are readonly ([#​8473](DataDog/dd-trace-java#8473) - [@​vandonr](https://github.com/vandonr)) - π Fix bug on proto schema extraction ([#​8403](DataDog/dd-trace-java#8403) - [@​vandonr](https://github.com/vandonr)) - π Fix service name overrides in consumers ([#​8387](DataDog/dd-trace-java#8387) - [@​piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - β¨ Add DBMTracePreparedStatements to tracer configuration log ([#​8508](DataDog/dd-trace-java#8508) - [@​cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - β¨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) - π Fix Exception Replay with Lambda proxy classes ([#​8452](DataDog/dd-trace-java#8452) - [@​jpbempel](https://github.com/jpbempel)) - β¨ Add code origin support for spring-webmvc ([#​8416](DataDog/dd-trace-java#8416) - [@​evanchooly](https://github.com/evanchooly)) - β¨ Add support for scanning jar from loaded class ([#​8370](DataDog/dd-trace-java#8370) - [@​jpbempel](https://github.com/jpbempel)) - π Disable capture of entry values ([#​8369](DataDog/dd-trace-java#8369) - [@​jpbempel](https://github.com/jpbempel)) - π Fix CodeOrigin for `@Trace` annotation ([#​8344](DataDog/dd-trace-java#8344) - [@​jpbempel](https://github.com/jpbempel)) - π Fix equals/hashCode for CodeOrigin probe ([#​8319](DataDog/dd-trace-java#8319) - [@​jpbempel](https://github.com/jpbempel)) - β¨ Add code origin support to kafka message listeners ([#​8301](DataDog/dd-trace-java#8301) - [@​evanchooly](https://github.com/evanchooly)) ##### Metrics - β¨ Create metric: appsec.waf.error ([#​8381](DataDog/dd-trace-java#8381) - [@​sezen-datadog](https://github.com/sezen-datadog)) - β¨ Create metric: appsec.rasp.error ([#​8364](DataDog/dd-trace-java#8364) - [@​sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - β¨ Bump ddprof library to 1.22.0 ([#​8463](DataDog/dd-trace-java#8463) - [@​jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - π Exclude OrderedThreadPoolExecutor from queue-time measurements ([#​8456](DataDog/dd-trace-java#8456) - [@​jbachorik](https://github.com/jbachorik)) - β¨ Record JVM info on JVMs without JFR ([#​8431](DataDog/dd-trace-java#8431) - [@​jbachorik](https://github.com/jbachorik)) - π Actually use CleanupTask in TempLocationManager ([#​8420](DataDog/dd-trace-java#8420) - [@​mcculls](https://github.com/mcculls)) - β¨ Only fork jps when required ([#​8419](DataDog/dd-trace-java#8419) - [@​mcculls](https://github.com/mcculls)) - π Adjust JFR checks for J9 ([#​8405](DataDog/dd-trace-java#8405) - [@​jbachorik](https://github.com/jbachorik)) - π§Ή Disable smap RSS parsing by default ([#​8342](DataDog/dd-trace-java#8342) - [@​MattAlp](https://github.com/MattAlp)) ##### Telemetry - π Add support for JBoss jar:file format to DependencyResolver ([#​8428](DataDog/dd-trace-java#8428) - [@​jandro996](https://github.com/jandro996)) - β¨ Update metrics: appsec.waf.requests ([#​8353](DataDog/dd-trace-java#8353) - [@​Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - β¨ Introduce tracing propagator ([#​8313](DataDog/dd-trace-java#8313) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - π Fix Stable Config telemetry source names ([#​8460](DataDog/dd-trace-java#8460) - [@​BaptisteFoy](https://github.com/BaptisteFoy)) - β¨ Probe trace endpoints with a valid payload of empty arrays ([#​8414](DataDog/dd-trace-java#8414) - [@​mcculls](https://github.com/mcculls)) - β¨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#​8399](DataDog/dd-trace-java#8399) - [@​mcculls](https://github.com/mcculls)) - β¨ Migrate DSM injection calls to context-first APIs ([#​8383](DataDog/dd-trace-java#8383) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - π§Ή Move continuation capture methods from scope to tracer ([#​8371](DataDog/dd-trace-java#8371) - [@​mcculls](https://github.com/mcculls)) - β¨ Migrate context extraction calls to context-first APIs ([#​8368](DataDog/dd-trace-java#8368) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - π§Ή Migrate context injection calls to context-first APIs ([#​8358](DataDog/dd-trace-java#8358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - π‘ Support reading configurations from files ([#​8338](DataDog/dd-trace-java#8338) - [@​mtoffl01](https://github.com/mtoffl01)) - π‘ Implementation of BaggagePropagator and BaggageContext ([#​8330](DataDog/dd-trace-java#8330) - [@​mhlidd](https://github.com/mhlidd)) - π§Ή Combine continuation implementations into one which supports multiple activations ([#​8324](DataDog/dd-trace-java#8324) - [@​mcculls](https://github.com/mcculls)) - β¨ Introduce tracing propagator ([#​8313](DataDog/dd-trace-java#8313) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - β¨ Remove old context propagation API ([#​8271](DataDog/dd-trace-java#8271) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - π Send error message and stack to Lambda extension ([#​8417](DataDog/dd-trace-java#8417) - [@​nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - π Fix error happening when sqs message attributes are readonly ([#​8473](DataDog/dd-trace-java#8473) - [@​vandonr](https://github.com/vandonr)) - π‘ Inject trace context into AWS Step Functions input ([#​7585](DataDog/dd-trace-java#7585) - [@​DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - β¨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) - β¨ Add code origin support for spring-webmvc ([#​8416](DataDog/dd-trace-java#8416) - [@​evanchooly](https://github.com/evanchooly)) - π‘ Implementation of BaggagePropagator and BaggageContext ([#​8330](DataDog/dd-trace-java#8330) - [@​mhlidd](https://github.com/mhlidd)) - β¨ Add code origin support to kafka message listeners ([#​8301](DataDog/dd-trace-java#8301) - [@​evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - β¨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - β¨ Add messaging.destination.name tag to kafka integrations ([#​8366](DataDog/dd-trace-java#8366) - [@​rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - π Fix bug on proto schema extraction ([#​8403](DataDog/dd-trace-java#8403) - [@​vandonr](https://github.com/vandonr)) </details> --- ### Configuration π **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Never, or you tick the rebase/retry checkbox. π» **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa
What Does This Do
Fixes Gradle Launcher instrumentation.
The tracer patches Gradle Launcher and injects itself into the Gradle Daemon that the launcher starts, by modifying the list of args use for the daemon's JVM.
Projects that are Gradle plugins or extensions use Gradle Test Kit to test their logic.
It is possible to configure Gradle Test Kit to fork a Gradle instance (rather than run an "embedded" one).
When this instance is forked inside a test, Gradle Launcher is used to start it.
When a test starts a Gradle instance, we don't want to patch that Gradle launcher, as we don't want to trace corresponding Gradle build.
Additional Notes
Other fixes included in the PR:
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]