Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. #9556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. #9556

wants to merge 9 commits into from

Conversation

AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Sep 18, 2025 •
edited
Loading

What Does This Do

Refactors test assertions from AssertJ, Hamcrest and Google.Truth to JUnit5.Assertions.

Motivation

Nearly all tests already use JUnit5 or Spock assertions.
Only a handful of classes relied on AssertJ, Hamcrest and Google.Truth.
Consolidating on fewer assertion libraries simplifies the codebase and reduces maintenance overhead.
For context: JUnit5 assertions are used in 5,000+ places, while others combined appear in fewer than 150-200.

Pros & Cons

Pros

  • Unified and consistent style across the codebase.
  • No need for contributors to learn multiple assertion frameworks.
  • Fewer libraries to support and update; JUnit5 is required regardless.
  • Easier onboarding for new developers who only need to know JUnit5.
  • Reduces risk of mixing assertion styles in the same test, which can hurt readability.

Cons

  • JUnit5 assertions are less feature-rich than AssertJ.
  • Complex assertion scenarios may require adding helper functions.
  • Migration effort may introduce minor noise in diffs (less meaningful changes).
  • Potential loss of fluent/chainable assertion style, which some find more readable.

Additional Notes

AssertJ remains as a runtime-only dependency for kafka-clients-0.11 tests, where it is still required.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Sep 18, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring labels Sep 18, 2025
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/refactor-assertj-to-junit
git_commit_date 1758219687 1758226288
git_commit_sha 1052f49 3551d25
release_version 1.54.0-SNAPSHOT~1052f4935d 1.54.0-SNAPSHOT~3551d2500e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758228116 1758228116
ci_job_id 1137152802 1137152802
ci_pipeline_id 76922369 76922369
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-yhxynob4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-yhxynob4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067465
Total [baseline] (8.697 s) : 0, 8696910
Agent [candidate] (1.063 s) : 0, 1063061
Total [candidate] (8.599 s) : 0, 8598744
section iast
Agent [baseline] (1.189 s) : 0, 1189159
Total [baseline] (9.279 s) : 0, 9278674
Agent [candidate] (1.2 s) : 0, 1199696
Total [candidate] (9.342 s) : 0, 9342115
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.189 s 121.694 ms (11.4%)
Total tracing 8.697 s -
Total iast 9.279 s 581.764 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.2 s 136.635 ms (12.9%)
Total tracing 8.599 s -
Total iast 9.342 s 743.371 ms (8.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (737.419 ms) : 0, 737419
BytebuddyAgent [candidate] (734.55 ms) : 0, 734550
GlobalTracer [baseline] (253.777 ms) : 0, 253777
GlobalTracer [candidate] (252.952 ms) : 0, 252952
AppSec [baseline] (30.881 ms) : 0, 30881
AppSec [candidate] (30.515 ms) : 0, 30515
Debugger [baseline] (6.444 ms) : 0, 6444
Debugger [candidate] (6.414 ms) : 0, 6414
Remote Config [baseline] (706.324 µs) : 0, 706
Remote Config [candidate] (690.727 µs) : 0, 691
Telemetry [baseline] (15.652 ms) : 0, 15652
Telemetry [candidate] (15.538 ms) : 0, 15538
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.498 ms) : 0, 1498
BytebuddyAgent [baseline] (852.033 ms) : 0, 852033
BytebuddyAgent [candidate] (859.46 ms) : 0, 859460
GlobalTracer [baseline] (245.508 ms) : 0, 245508
GlobalTracer [candidate] (246.068 ms) : 0, 246068
AppSec [baseline] (24.367 ms) : 0, 24367
AppSec [candidate] (28.207 ms) : 0, 28207
Debugger [baseline] (6.016 ms) : 0, 6016
Debugger [candidate] (6.063 ms) : 0, 6063
Remote Config [baseline] (582.359 µs) : 0, 582
Remote Config [candidate] (605.792 µs) : 0, 606
Telemetry [baseline] (8.031 ms) : 0, 8031
Telemetry [candidate] (8.274 ms) : 0, 8274
IAST [baseline] (30.231 ms) : 0, 30231
IAST [candidate] (28.497 ms) : 0, 28497
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065299
Total [baseline] (10.789 s) : 0, 10788526
Agent [candidate] (1.071 s) : 0, 1071496
Total [candidate] (10.754 s) : 0, 10754148
section appsec
Agent [baseline] (1.249 s) : 0, 1249472
Total [baseline] (11.069 s) : 0, 11068572
Agent [candidate] (1.242 s) : 0, 1242485
Total [candidate] (11.031 s) : 0, 11030771
section iast
Agent [baseline] (1.209 s) : 0, 1208821
Total [baseline] (11.154 s) : 0, 11154482
Agent [candidate] (1.195 s) : 0, 1194530
Total [candidate] (11.034 s) : 0, 11034350
section profiling
Agent [baseline] (1.214 s) : 0, 1214444
Total [baseline] (10.957 s) : 0, 10956920
Agent [candidate] (1.212 s) : 0, 1212039
Total [candidate] (10.883 s) : 0, 10882777
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.249 s 184.173 ms (17.3%)
Agent iast 1.209 s 143.522 ms (13.5%)
Agent profiling 1.214 s 149.145 ms (14.0%)
Total tracing 10.789 s -
Total appsec 11.069 s 280.046 ms (2.6%)
Total iast 11.154 s 365.957 ms (3.4%)
Total profiling 10.957 s 168.394 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.242 s 170.989 ms (16.0%)
Agent iast 1.195 s 123.034 ms (11.5%)
Agent profiling 1.212 s 140.542 ms (13.1%)
Total tracing 10.754 s -
Total appsec 11.031 s 276.623 ms (2.6%)
Total iast 11.034 s 280.202 ms (2.6%)
Total profiling 10.883 s 128.629 ms (1.2%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (734.937 ms) : 0, 734937
BytebuddyAgent [candidate] (739.906 ms) : 0, 739906
GlobalTracer [baseline] (253.571 ms) : 0, 253571
GlobalTracer [candidate] (254.374 ms) : 0, 254374
AppSec [baseline] (30.787 ms) : 0, 30787
AppSec [candidate] (30.971 ms) : 0, 30971
Debugger [baseline] (6.452 ms) : 0, 6452
Debugger [candidate] (6.477 ms) : 0, 6477
Remote Config [baseline] (695.313 µs) : 0, 695
Remote Config [candidate] (694.707 µs) : 0, 695
Telemetry [baseline] (16.328 ms) : 0, 16328
Telemetry [candidate] (16.41 ms) : 0, 16410
section appsec
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (766.58 ms) : 0, 766580
BytebuddyAgent [candidate] (761.853 ms) : 0, 761853
GlobalTracer [baseline] (248.627 ms) : 0, 248627
GlobalTracer [candidate] (247.317 ms) : 0, 247317
IAST [baseline] (24.108 ms) : 0, 24108
IAST [candidate] (23.963 ms) : 0, 23963
AppSec [baseline] (172.076 ms) : 0, 172076
AppSec [candidate] (171.44 ms) : 0, 171440
Debugger [baseline] (6.066 ms) : 0, 6066
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (637.376 µs) : 0, 637
Remote Config [candidate] (619.166 µs) : 0, 619
Telemetry [baseline] (8.601 ms) : 0, 8601
Telemetry [candidate] (8.456 ms) : 0, 8456
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (866.916 ms) : 0, 866916
BytebuddyAgent [candidate] (854.478 ms) : 0, 854478
GlobalTracer [baseline] (247.033 ms) : 0, 247033
GlobalTracer [candidate] (247.718 ms) : 0, 247718
IAST [baseline] (30.824 ms) : 0, 30824
IAST [candidate] (28.326 ms) : 0, 28326
AppSec [baseline] (26.41 ms) : 0, 26410
AppSec [candidate] (26.622 ms) : 0, 26622
Debugger [baseline] (6.144 ms) : 0, 6144
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (603.199 µs) : 0, 603
Remote Config [candidate] (614.039 µs) : 0, 614
Telemetry [baseline] (8.257 ms) : 0, 8257
Telemetry [candidate] (8.198 ms) : 0, 8198
section profiling
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (764.278 ms) : 0, 764278
BytebuddyAgent [candidate] (763.317 ms) : 0, 763317
GlobalTracer [baseline] (233.659 ms) : 0, 233659
GlobalTracer [candidate] (232.796 ms) : 0, 232796
AppSec [baseline] (30.669 ms) : 0, 30669
AppSec [candidate] (30.524 ms) : 0, 30524
Debugger [baseline] (12.99 ms) : 0, 12990
Debugger [candidate] (12.816 ms) : 0, 12816
Remote Config [baseline] (1.548 ms) : 0, 1548
Remote Config [candidate] (1.485 ms) : 0, 1485
Telemetry [baseline] (9.436 ms) : 0, 9436
Telemetry [candidate] (9.314 ms) : 0, 9314
ProfilingAgent [baseline] (109.177 ms) : 0, 109177
ProfilingAgent [candidate] (109.117 ms) : 0, 109117
Profiling [baseline] (109.815 ms) : 0, 109815
Profiling [candidate] (109.769 ms) : 0, 109769
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/refactor-assertj-to-junit
git_commit_date 1758219687 1758226288
git_commit_sha 1052f49 3551d25
release_version 1.54.0-SNAPSHOT~1052f4935d 1.54.0-SNAPSHOT~3551d2500e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758227781 1758227781
ci_job_id 1137152803 1137152803
ci_pipeline_id 76922369 76922369
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-abj88vi9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-abj88vi9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:tracing:high_load worse
[+291.350µs; +536.153µs] or [+3.780%; +6.955%]		 unstable
[-97.227op/s; +37.039op/s] or [-16.184%; +6.166%]		 8.122ms 570.656op/s 7.709ms 600.750op/s
scenario:load:petclinic:tracing:high_load better
[-2.083ms; -1.285ms] or [-4.761%; -2.938%]		 unstable
[-3.422op/s; +11.822op/s] or [-3.199%; +11.052%]		 42.057ms 111.162op/s 43.741ms 106.963op/s
scenario:load:petclinic:profiling:high_load worse
[+0.977ms; +1.957ms] or [+2.056%; +4.117%]		 unstable
[-9.923op/s; +3.998op/s] or [-10.082%; +4.062%]		 49.009ms 95.463op/s 47.542ms 98.425op/s
scenario:load:petclinic:code_origins:high_load better
[-3.076ms; -2.222ms] or [-6.622%; -4.783%]		 unstable
[-1.007op/s; +13.107op/s] or [-1.000%; +13.011%]		 43.800ms 106.787op/s 46.448ms 100.737op/s
scenario:load:petclinic:iast:high_load worse
[+1.303ms; +2.135ms] or [+2.947%; +4.827%]		 unstable
[-11.005op/s; +3.080op/s] or [-10.405%; +2.912%]		 45.944ms 101.812op/s 44.225ms 105.775op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.401 ms) : 4345, 4456
.   : milestone, 4401,
iast (9.406 ms) : 9249, 9562
.   : milestone, 9406,
iast_FULL (14.336 ms) : 14053, 14619
.   : milestone, 14336,
iast_GLOBAL (10.881 ms) : 10684, 11078
.   : milestone, 10881,
profiling (8.913 ms) : 8774, 9051
.   : milestone, 8913,
tracing (7.709 ms) : 7600, 7817
.   : milestone, 7709,
section candidate
no_agent (4.499 ms) : 4448, 4551
.   : milestone, 4499,
iast (9.341 ms) : 9189, 9492
.   : milestone, 9341,
iast_FULL (14.537 ms) : 14247, 14827
.   : milestone, 14537,
iast_GLOBAL (10.553 ms) : 10368, 10738
.   : milestone, 10553,
profiling (8.987 ms) : 8837, 9138
.   : milestone, 8987,
tracing (8.122 ms) : 8004, 8241
.   : milestone, 8122,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.401 ms [4.345 ms, 4.456 ms] -
iast 9.406 ms [9.249 ms, 9.562 ms] 5.005 ms (113.7%)
iast_FULL 14.336 ms [14.053 ms, 14.619 ms] 9.936 ms (225.8%)
iast_GLOBAL 10.881 ms [10.684 ms, 11.078 ms] 6.48 ms (147.3%)
profiling 8.913 ms [8.774 ms, 9.051 ms] 4.512 ms (102.5%)
tracing 7.709 ms [7.6 ms, 7.817 ms] 3.308 ms (75.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.499 ms [4.448 ms, 4.551 ms] -
iast 9.341 ms [9.189 ms, 9.492 ms] 4.841 ms (107.6%)
iast_FULL 14.537 ms [14.247 ms, 14.827 ms] 10.038 ms (223.1%)
iast_GLOBAL 10.553 ms [10.368 ms, 10.738 ms] 6.053 ms (134.5%)
profiling 8.987 ms [8.837 ms, 9.138 ms] 4.488 ms (99.7%)
tracing 8.122 ms [8.004 ms, 8.241 ms] 3.623 ms (80.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.072 ms) : 36763, 37380
.   : milestone, 37072,
appsec (48.15 ms) : 47726, 48574
.   : milestone, 48150,
code_origins (46.448 ms) : 46035, 46862
.   : milestone, 46448,
iast (44.225 ms) : 43840, 44611
.   : milestone, 44225,
profiling (47.542 ms) : 47083, 48001
.   : milestone, 47542,
tracing (43.741 ms) : 43362, 44120
.   : milestone, 43741,
section candidate
no_agent (37.436 ms) : 37134, 37738
.   : milestone, 37436,
appsec (48.398 ms) : 47967, 48830
.   : milestone, 48398,
code_origins (43.8 ms) : 43420, 44179
.   : milestone, 43800,
iast (45.944 ms) : 45557, 46332
.   : milestone, 45944,
profiling (49.009 ms) : 48558, 49461
.   : milestone, 49009,
tracing (42.057 ms) : 41695, 42419
.   : milestone, 42057,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.072 ms [36.763 ms, 37.38 ms] -
appsec 48.15 ms [47.726 ms, 48.574 ms] 11.078 ms (29.9%)
code_origins 46.448 ms [46.035 ms, 46.862 ms] 9.377 ms (25.3%)
iast 44.225 ms [43.84 ms, 44.611 ms] 7.154 ms (19.3%)
profiling 47.542 ms [47.083 ms, 48.001 ms] 10.47 ms (28.2%)
tracing 43.741 ms [43.362 ms, 44.12 ms] 6.669 ms (18.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.436 ms [37.134 ms, 37.738 ms] -
appsec 48.398 ms [47.967 ms, 48.83 ms] 10.962 ms (29.3%)
code_origins 43.8 ms [43.42 ms, 44.179 ms] 6.364 ms (17.0%)
iast 45.944 ms [45.557 ms, 46.332 ms] 8.508 ms (22.7%)
profiling 49.009 ms [48.558 ms, 49.461 ms] 11.573 ms (30.9%)
tracing 42.057 ms [41.695 ms, 42.419 ms] 4.621 ms (12.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/refactor-assertj-to-junit
git_commit_date 1758219687 1758226288
git_commit_sha 1052f49 3551d25
release_version 1.54.0-SNAPSHOT~1052f4935d 1.54.0-SNAPSHOT~3551d2500e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1758228277 1758228277
ci_job_id 1137152804 1137152804
ci_pipeline_id 76922369 76922369
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-8h1igu04 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-8h1igu04 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.783 s) : 14783000, 14783000
.   : milestone, 14783000,
appsec (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
iast (18.58 s) : 18580000, 18580000
.   : milestone, 18580000,
iast_GLOBAL (18.181 s) : 18181000, 18181000
.   : milestone, 18181000,
profiling (15.425 s) : 15425000, 15425000
.   : milestone, 15425000,
tracing (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
section candidate
no_agent (15.007 s) : 15007000, 15007000
.   : milestone, 15007000,
appsec (14.762 s) : 14762000, 14762000
.   : milestone, 14762000,
iast (18.407 s) : 18407000, 18407000
.   : milestone, 18407000,
iast_GLOBAL (17.875 s) : 17875000, 17875000
.   : milestone, 17875000,
profiling (15.514 s) : 15514000, 15514000
.   : milestone, 15514000,
tracing (14.845 s) : 14845000, 14845000
.   : milestone, 14845000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.783 s [14.783 s, 14.783 s] -
appsec 14.916 s [14.916 s, 14.916 s] 133.0 ms (0.9%)
iast 18.58 s [18.58 s, 18.58 s] 3.797 s (25.7%)
iast_GLOBAL 18.181 s [18.181 s, 18.181 s] 3.398 s (23.0%)
profiling 15.425 s [15.425 s, 15.425 s] 642.0 ms (4.3%)
tracing 14.959 s [14.959 s, 14.959 s] 176.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.007 s [15.007 s, 15.007 s] -
appsec 14.762 s [14.762 s, 14.762 s] -245.0 ms (-1.6%)
iast 18.407 s [18.407 s, 18.407 s] 3.4 s (22.7%)
iast_GLOBAL 17.875 s [17.875 s, 17.875 s] 2.868 s (19.1%)
profiling 15.514 s [15.514 s, 15.514 s] 507.0 ms (3.4%)
tracing 14.845 s [14.845 s, 14.845 s] -162.0 ms (-1.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3551d2500e, baseline=1.54.0-SNAPSHOT~1052f4935d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.702 ms) : 3486, 3918
.   : milestone, 3702,
iast (2.195 ms) : 2133, 2258
.   : milestone, 2195,
iast_GLOBAL (2.238 ms) : 2175, 2301
.   : milestone, 2238,
profiling (2.044 ms) : 1994, 2095
.   : milestone, 2044,
tracing (2.027 ms) : 1978, 2077
.   : milestone, 2027,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.705 ms) : 3487, 3922
.   : milestone, 3705,
iast (2.194 ms) : 2132, 2257
.   : milestone, 2194,
iast_GLOBAL (2.25 ms) : 2186, 2314
.   : milestone, 2250,
profiling (2.048 ms) : 1997, 2099
.   : milestone, 2048,
tracing (2.027 ms) : 1978, 2076
.   : milestone, 2027,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 3.702 ms [3.486 ms, 3.918 ms] 2.227 ms (151.0%)
iast 2.195 ms [2.133 ms, 2.258 ms] 720.522 µs (48.9%)
iast_GLOBAL 2.238 ms [2.175 ms, 2.301 ms] 763.117 µs (51.7%)
profiling 2.044 ms [1.994 ms, 2.095 ms] 569.5 µs (38.6%)
tracing 2.027 ms [1.978 ms, 2.077 ms] 552.489 µs (37.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 3.705 ms [3.487 ms, 3.922 ms] 2.23 ms (151.2%)
iast 2.194 ms [2.132 ms, 2.257 ms] 719.556 µs (48.8%)
iast_GLOBAL 2.25 ms [2.186 ms, 2.314 ms] 775.525 µs (52.6%)
profiling 2.048 ms [1.997 ms, 2.099 ms] 572.938 µs (38.9%)
tracing 2.027 ms [1.978 ms, 2.076 ms] 552.344 µs (37.5%)

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Sep 18, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.77% (-0.04%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3551d25 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2025 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/refactor-assertj-to-junit
git_commit_date 1758219687 1758223504
git_commit_sha 1052f49 b336490
See matching parameters
Baseline Candidate
ci_job_date 1758224590 1758224590
ci_job_id 1137037157 1137037157
ci_pipeline_id 76915704 76915704
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2025 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/refactor-assertj-to-junit
git_commit_date 1758193224 1758215917
git_commit_sha f44ec39 aa58532
See matching parameters
Baseline Candidate
ci_job_date 1758217197 1758217197
ci_job_id 1136720641 1136720641
ci_pipeline_id 76897802 76897802
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume unsure
[-6664.266op/s; -221.317op/s] or [-3.759%; -0.125%]

PerfectSlayer
PerfectSlayer reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting changes! Thanks for cleaning up the code base 🤝
(commenting only as it's still a draft)

bric3
bric3 approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an opinion, but I don't see the value to remove AssertJ assertions. This library is generally better equiped than Junit (Jupiter) assertions, and it very readable.
I cannot speak for google truth, but this seems a bit redundant wih AssertJ.

@AlexeyKuznetsov-DD
Copy link
Contributor Author

Interesting changes! Thanks for cleaning up the code base 🤝 (commenting only as it's still a draft)

Yep, just added to PR description my motivation and Pros & Cons.

@AlexeyKuznetsov-DD
Copy link
Contributor Author

This is an opinion, but I don't see the value to remove AssertJ assertions. This library is generally better equiped than Junit (Jupiter) assertions, and it very readable. I cannot speak for google truth, but this seems a bit redundant wih AssertJ.

Probably yes, maybe I will get rid only of Truth and keep AssertJ, I'm still experimenting.

@bric3
Copy link
Contributor

bric3 commented Sep 18, 2025

I'm still experimenting.

My 2cts would be to convert the Junit one to assertj. While that's no small task, I believe there are some automated tools for that.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review September 18, 2025 15:15
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners September 18, 2025 15:15
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners September 18, 2025 17:18
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from daniel-mohedano and sezen-datadog and removed request for a team September 18, 2025 17:18
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the title Refactored AssertJ and Google.Truth to Junit5.Assertions. Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. Sep 18, 2025
ygree
ygree approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for cleaning this up!

sarahchen6
sarahchen6 approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bric3 bric3 bric3 approved these changes

@ygree ygree ygree approved these changes

@sarahchen6 sarahchen6 sarahchen6 approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

@daniel-mohedano daniel-mohedano Awaiting requested review from daniel-mohedano daniel-mohedano is a code owner automatically assigned from DataDog/ci-app-libraries-java

@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog is a code owner automatically assigned from DataDog/asm-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-lang-platform-java

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

Assignees

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD

Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexeyKuznetsov-DD @bric3 @PerfectSlayer @ygree @sarahchen6