Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. #9556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. #9556

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
122cec8
Refactor `AssertJ` to `JUnit5.Assertions` for unification.
AlexeyKuznetsov-DD Sep 17, 2025
92f4914
Fixed runtime dependency.
AlexeyKuznetsov-DD Sep 18, 2025
cbd6282
Removed Truth.
AlexeyKuznetsov-DD Sep 18, 2025
cf30ba9
Minor fixes.
AlexeyKuznetsov-DD Sep 18, 2025
b5dace5
Merge branch 'master' into alexeyk/refactor-assertj-to-junit
AlexeyKuznetsov-DD Sep 18, 2025
aa58532
Refactored `Hamcrest` to `JUnit5`.
AlexeyKuznetsov-DD Sep 18, 2025
b336490
Merge branch 'master' into alexeyk/refactor-assertj-to-junit
AlexeyKuznetsov-DD Sep 18, 2025
85aaa2c
Fixed review comments.
AlexeyKuznetsov-DD Sep 18, 2025
3551d25
Fixed review comments.
AlexeyKuznetsov-DD Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed review comments.
  • Loading branch information
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD committed Sep 18, 2025
commit 3551d2500ea6580e510b158ab23b1ae7dd272cd1
4 changes: 3 additions & 1 deletion ...tion/maven-3.2.1/src/test/groovy/datadog/trace/instrumentation/maven3/MavenUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,11 @@ private boolean assertGetEffectiveJvmFallbackUsesToolchains(ExecutionEvent execu
if (!MavenUtils.isTestExecution(mojoExecution)) {
return false;
}

MavenSession session = executionEvent.getSession();
String effectiveJvm = MavenUtils.getEffectiveJvmFallback(session, mojoExecution);
assertNotNull("/my-jdk-home/bin/java", effectiveJvm);
assertNotNull(effectiveJvm);
assertTrue(effectiveJvm.endsWith("/my-jdk-home/bin/java"));
return true;
}

Expand Down