Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Initial version of migration guide #28832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 19, 2025
Merged

Conversation

Dalje-et
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Copy link
Contributor

github-actions bot commented Apr 17, 2025

@Dalje-et Dalje-et marked this pull request as ready for review May 5, 2025 08:48
@Dalje-et Dalje-et requested a review from a team as a code owner May 5, 2025 08:48
@drichards-87 drichards-87 self-assigned this May 5, 2025
@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review label May 5, 2025
@drichards-87 drichards-87 removed their assignment May 5, 2025
@drichards-87
Copy link
Contributor

Created DOCS-10789 for Docs Team review.

@drichards-87 drichards-87 self-requested a review May 12, 2025 17:10
@drichards-87
Copy link
Contributor

drichards-87 commented May 12, 2025

HI @Dalje-et. Just letting you know that I'll be the one taking on the review. I'll try to have it done by end-of-day tomorrow at the latest. Feel free to reach out if you need anything. Thanks!

@datadog-datadog-prod-us1
Copy link

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion and a question on top of the commit I just pushed.

[2]: /integrations/
[3]: /monitors/notify/#bulk-editing-monitor--handles
[4]: /on_call/teams/
[5]: https://www.google.com
Copy link
Contributor

@drichards-87 drichards-87 May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text for this link mentions a migration tool, but the actual link takes you to the main Google page. Do you have a link to the migration tool that I can add?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I do :D It's still in here: #29306

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dalje-et Thanks for clarifying. The other guide will also need to be reviewed. Are you okay with waiting to publish this guide until after the migration tool guide has been reviewed and published?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a closer look at the other PR. In this guide, we refer to a "dedicated migration tool", but the tool is really more of a step-by-step guide. I think we should update the paragraph where we mention the tool and instead refer to it as a guide. I'd also advocate for converting it into a note, as it's more of a callout vs. a required step.

@NancyZ278
Copy link
Contributor

@drichards-87 Covering for @Dalje-et while he is away and was wondering if there is anything else left open on this PR?

@drichards-87
Copy link
Contributor

Hi @NancyZ278. There was a dependency on PR 29306. However, it looks like the PR has since been merged. I will update this PR and then merge it after the build job checks complete.

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 19, 2025

View all feedbacks in Devflow UI.

2025-05-19 20:22:02 UTC ℹ️ Start processing command /merge


2025-05-19 20:22:07 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-19 20:47:05 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f9c15f9 into master May 19, 2025
18 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daljeet/migration-guide branch May 19, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants