-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Initial version of migration guide #28832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
Created DOCS-10789 for Docs Team review. |
HI @Dalje-et. Just letting you know that I'll be the one taking on the review. I'll try to have it done by end-of-day tomorrow at the latest. Feel free to reach out if you need anything. Thanks! |
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor suggestion and a question on top of the commit I just pushed.
[2]: /integrations/ | ||
[3]: /monitors/notify/#bulk-editing-monitor--handles | ||
[4]: /on_call/teams/ | ||
[5]: https://www.google.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text for this link mentions a migration tool, but the actual link takes you to the main Google page. Do you have a link to the migration tool that I can add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I do :D It's still in here: #29306
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dalje-et Thanks for clarifying. The other guide will also need to be reviewed. Are you okay with waiting to publish this guide until after the migration tool guide has been reviewed and published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a closer look at the other PR. In this guide, we refer to a "dedicated migration tool", but the tool is really more of a step-by-step guide. I think we should update the paragraph where we mention the tool and instead refer to it as a guide. I'd also advocate for converting it into a note, as it's more of a callout vs. a required step.
Co-authored-by: DeForest Richards <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes