Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Choose better default allocation and conductance distribution settings #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoerivanEngelen opened this issue Jan 28, 2025 · 0 comments Β· Fixed by #1393
Closed

Choose better default allocation and conductance distribution settings #1392

JoerivanEngelen opened this issue Jan 28, 2025 · 0 comments Β· Fixed by #1393
Assignees
Milestone

Comments

@JoerivanEngelen
Copy link
Contributor

Some of our defaults settings are not optimal, and I think we can stick more to iMOD5.
We can argue that not all of iMOD5's defaults are optimal (thinking of #1391).
But I see other default settings as well in iMOD5 which are nicer:

Allocation

For DRN, we now have: ALLOCATION_OPTION.first_active_to_elevation. iMOD5 has ALLOCATION_OPTION.at_elevation, which fits tile drainage better.

For RIV, we now have: ALLOCATION_OPTION.stage_to_riv_bot_drn_above which is the most advanced option. Adding drains as well, which might be counter-intuitive. iMOD5 has ALLOCATION_OPTION.stage_to_riv_bot. I think this is nice enough.

Distribution

When we change the DRN allocation, we can also choose a much simpler conductance distributing option. We can stick to what is chosen for the GHB here and use DISTRIBUTING_OPTION.by_layer_transmissivity. We could choose an even more lightweight option here, as at_elevation always allocates to a single layer, so no distribution is required. I think to be safe, I want to avoid using by_corrected_transmissivity, as I'm not sure yet whether the correction could result in nasty edge cases for single layers and is more computationally intensive. On the other hand, if a user sets ALLOCATION_OPTION.first_active_to_elevation and forgets to set the conductance distrubtion option, having the simplest distribution method probably yields bad results. So I think for now DISTRIBUTING_OPTION.by_layer_transmissivity is the optimal choice.

@github-project-automation github-project-automation bot moved this to πŸ“― New in iMOD Suite Jan 28, 2025
@JoerivanEngelen JoerivanEngelen added this to the v1.0 release milestone Jan 28, 2025
@JoerivanEngelen JoerivanEngelen self-assigned this Jan 28, 2025
@JoerivanEngelen JoerivanEngelen moved this from πŸ“― New to πŸ— In Progress in iMOD Suite Jan 28, 2025
@JoerivanEngelen JoerivanEngelen moved this from πŸ— In Progress to 🧐 In Review in iMOD Suite Jan 28, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 28, 2025
Fixes #1392 

# Description
Changes default to better match iMOD5. 

- Reverted the default of ``SimulationAllocationOptions.riv`` back to
what it was in the previous version, as this matches iMOD5's default
setting.
- Set ``SimulationAllocationOptions.drn`` to
``ALLOCATION_OPTION.at_elevation``, to match iMOD5's default setting.

# Checklist

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [ ] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🧐 In Review to βœ… Done in iMOD Suite Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: βœ… Done
Development

Successfully merging a pull request may close this issue.

1 participant