Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WQ: Spaces in paths in runfile: quotes should be added #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manangka opened this issue Jan 4, 2023 · 1 comment · Fixed by #1517
Closed

WQ: Spaces in paths in runfile: quotes should be added #305

Manangka opened this issue Jan 4, 2023 · 1 comment · Fixed by #1517

Comments

@Manangka
Copy link
Collaborator

Manangka commented Jan 4, 2023

In GitLab by @gmcmjanssen on Jan 4, 2023, 18:04

I noticed that when a model is put in a folder that has spaces in its name (e.g. in the Deltares OneDrive folder), iMOD-Python does not put the paths between quotes. This then results in an error in iMOD-WQ.

E.g:
[bas6]
ibound_l$ = c:/Users/janssen_gs/OneDrive - Stichting Deltares/DATA/PROMISCES/Henry/data/3-input/bas/ibound_l$.idf

Should be

[bas6]
ibound_l$ = "c:/Users/janssen_gs/OneDrive - Stichting Deltares/DATA/PROMISCES/Henry/data/3-input/bas/ibound_l$.idf"

@JoerivanEngelen JoerivanEngelen changed the title Spaces in paths in runfile: quotes should be added WQ: Spaces in paths in runfile: quotes should be added Mar 5, 2025
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Mar 5, 2025
@JoerivanEngelen JoerivanEngelen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2025
@github-project-automation github-project-automation bot moved this from 📯 New to ✅ Done in iMOD Suite Apr 17, 2025
@JoerivanEngelen
Copy link
Contributor

No developments are planned for the wq module.

JoerivanEngelen added a commit that referenced this issue Apr 28, 2025
Closes #305 

# Description

This throws an error when a user tries to write a model in a directory
with a space in it.

Follow-up to #1514

See my comment here:
#1514 (comment)

> Thanks for hotfixing this. FYI: This is not an immediate problem
anymore: I just talked to @TeunvanWoerkom, he moved to a drive without
spaces in the path.
> 
> I'm not sure if we should merge this, as the `wq` test bench doesn't
have the coverage of the `mf6` module. Most notably, we don't run a
model with iMOD-WQ to test if it breaks. The current `wq` module is
tried and tested in many projects, so that is sufficient to do work
with. I don't want to risk breaking it with changes.
> 
> Besides, Teun manually quoted the paths in his runfile to fix this and
then iMOD-WQ apparently also isn't able to deal with spaces in paths (at
least the version he used). It crashes upon attempting to create the
results directories.
> 
> Alternatively: We could raise an error if a user attempts to write a
`wq` model in a folder with a space in the path?


It turned out that adding quotes doesn't do the trick, as iMOD-WQ also
cannot handle spaces in paths, even when they are quoted in the runfile.
It crashes upon writing results.

# Checklist
<!---
Before requesting review, please go through this checklist:
-->

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants