Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #305 Throw error upon space in directory name. #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Apr 28, 2025

Closes #305

Description

This throws an error when a user tries to write a model in a directory with a space in it.

Follow-up to #1514

See my comment here: #1514 (comment)

Thanks for hotfixing this. FYI: This is not an immediate problem anymore: I just talked to @TeunvanWoerkom, he moved to a drive without spaces in the path.

I'm not sure if we should merge this, as the wq test bench doesn't have the coverage of the mf6 module. Most notably, we don't run a model with iMOD-WQ to test if it breaks. The current wq module is tried and tested in many projects, so that is sufficient to do work with. I don't want to risk breaking it with changes.

Besides, Teun manually quoted the paths in his runfile to fix this and then iMOD-WQ apparently also isn't able to deal with spaces in paths (at least the version he used). It crashes upon attempting to create the results directories.

Alternatively: We could raise an error if a user attempts to write a wq model in a folder with a space in the path?

It turned out that adding quotes doesn't do the trick, as iMOD-WQ also cannot handle spaces in paths, even when they are quoted in the runfile. It crashes upon writing results.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

Copy link

@JoerivanEngelen JoerivanEngelen requested a review from Huite April 28, 2025 09:51
Copy link
Contributor

@Huite Huite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoerivanEngelen JoerivanEngelen merged commit 51f1ead into master Apr 28, 2025
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#305_wq_error_upon_space_in_path branch April 28, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WQ: Spaces in paths in runfile: quotes should be added
2 participants