-
Notifications
You must be signed in to change notification settings - Fork 3
Should pyproject.toml have a dev dependencies section? #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also: shouldn't xugrid be included in the required dependencies, as well as e.g. dask? Since I remember an issue (from Hendrik?) where he couldn't read IDFs due to dask missing. |
I think the dev dependencies can be removed with the introduction of pixi.
Since #707, these have been added. I however, noticed a inconsitency in pinned packages: in pixi.toml Furthermore, another mistake is that |
Fixes #763 # Description <!--- Thanks for opening a PR! Please add your description here of changes made and how they are going to resolve the linked issue --> * Remove dev dependencies from pyproject.toml * Synchronizes package versions in with pyproject.toml and pixi.toml * Add hatchling to pixi.toml * Updates lock file # Checklist <!--- Before requesting review, please go through this checklist: --> - [x] Links to correct issue - [ ] Update changelog, if changes affect users - [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [ ] Unit tests were added - [ ] **If feature added**: Added/extended example
I wonder whether we still need a dev section for the pyproject toml.
Mostly, we expect people to install imod-python from conda-forge (or get it via Deltaforge). In that case, the whole pyproject dependencies aren't relevant, since it's the recipe that defines the dependencies.
However, we also release imod python on PyPI and there are people who do not use conda-forge (for whatever reason). For this reason, we've tried to keep a "minimal" version installable via pip, which is why we have the current required dependencies:
The more problematic stuff is things like netCDF4, GDAL, PROJ, etc. For this, the idea is that they're optional dependencies. They are available via optional-dependencies
all
, which should result in the same packages as the conda-forge install.For stuff that only developers need (sphinx, etc.), the dev deps are separate. However, since we expect/recommend to use pixi now, we might as well get rid of it?
The text was updated successfully, but these errors were encountered: