Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #763 remove dev dependencies #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Feb 5, 2024

Fixes #763

Description

  • Remove dev dependencies from pyproject.toml
  • Synchronizes package versions in with pyproject.toml and pixi.toml
  • Add hatchling to pixi.toml
  • Updates lock file

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

Copy link
Contributor

@luitjansl luitjansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, 1 question

@@ -544,24 +544,24 @@ package:
timestamp: 1693607226431
- platform: linux-64
name: aom
version: 3.8.1
version: 3.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version number was lowered. Is that intentional?

Copy link
Contributor Author

@JoerivanEngelen JoerivanEngelen Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, apparently pixi resolved the environment with this version. This happens every now and then. This usually is not a problem.

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Feb 5, 2024
Merged via the queue into master with commit 67fcbe6 Feb 5, 2024
@JoerivanEngelen JoerivanEngelen deleted the 763_remove_dev_dependencies branch February 5, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should pyproject.toml have a dev dependencies section?
2 participants