Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add split transport models to the right solution group #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luitjansl opened this issue Jan 29, 2024 · 0 comments
Closed

add split transport models to the right solution group #789

luitjansl opened this issue Jan 29, 2024 · 0 comments
Assignees

Comments

@luitjansl
Copy link
Contributor

a solution group contains numerical settings. Any number of models of the same type (Flow or transport) can form a solution group.
When splitting transport simulations, we want the split models to end up in the same solution group as the models that were split to create them.
So if we have a 3 species simulation (flow + 3 transport models) and species 1 and 2 are in solution group 1, whereas species 3 is in solution group 2, then we want the transport models obtained from splitting the species 1 and 2 models to go into solution group 1, whereas the models obtained by splitting the species 3 model should go to solution group 2.

@github-project-automation github-project-automation bot moved this to πŸ“― New in iMOD Suite Jan 29, 2024
@luitjansl luitjansl moved this from πŸ“― New to πŸ— In Progress in iMOD Suite Jan 30, 2024
@luitjansl luitjansl moved this from πŸ— In Progress to 🧐 In Review in iMOD Suite Jan 30, 2024
luitjansl added a commit that referenced this issue Feb 1, 2024
Fixes #788  and #789 

# Description
now adds split models to the solution group (ims) that the source model
belonged to.
When writing a split simulation with flow and transport, gwfgwt
exchanges are created. The models are connected based on type and
domain.

# Checklist

- [X]  Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example

---------

Co-authored-by: Joeri van Engelen <[email protected]>
@luitjansl luitjansl moved this from 🧐 In Review to βœ… Done in iMOD Suite Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: βœ… Done
Development

No branches or pull requests

1 participant