Issue #788 and # 789 gwf gwt exchanges and ims #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review comment Co-authored-by: Joeri van Engelen <[email protected]>
review comment Co-authored-by: Joeri van Engelen <[email protected]>
Manangka
reviewed
Jan 31, 2024
| new_simulation["solver"]["modelnames"] = xr.DataArray( | ||
| list(get_models(new_simulation).keys()) | ||
| ) | ||
| if isinstance(model, GroundwaterFlowModel): |
There was a problem hiding this comment.
An alternative to an if statement if passing the entire model to the method and then use typed dispatch to call the correct method
for model_name, model in original_models.items():
exchanges += exchange_creator.create_exchanges(
model_name, model
)
In the ExchangeCreator:
@typedispatch
def create_exchanges(
self, model_name: str, model: GroundwaterFlowModel
) -> List[GWFGWF]:
....
@typedispatch
def create_exchanges(
self, model_name: str, model: GroundwaterTransportModel
) -> List[GWFGWF]:
return []
There was a problem hiding this comment.
That may become a better alternative if the number of supported model types increases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788 and #789
Description
now adds split models to the solution group (ims) that the source model belonged to.
When writing a split simulation with flow and transport, gwfgwt exchanges are created. The models are connected based on type and domain.
Checklist
Issue #nr, e.g.Issue #737