Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validation concentrations missing in some packages #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoerivanEngelen opened this issue Feb 1, 2024 · 0 comments · Fixed by #808
Closed

Validation concentrations missing in some packages #805

JoerivanEngelen opened this issue Feb 1, 2024 · 0 comments · Fixed by #808
Assignees
@JoerivanEngelen

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Feb 1, 2024 •
edited
Loading

I got a message from @tvw11 that he ran into a hard crash with Modflow 6 when writing a combination of DRN and SSM package with inconsistent datasets: The concentrations had np.nan in cells where data was specified in the DRN package, which caused a nan written to the auxiliary column. At minimum, we should validate the concentrations upon writing the DRN package as well.

List of packages where validation of concentrations is missing:

  • DRN
  • EVT
  • WEL

The WEL might be something to pick up in a separate issue, as the validation in this package is lacking anyway.
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Feb 1, 2024
@JoerivanEngelen JoerivanEngelen changed the title Add validation concentrations/ SSM package Add validation concentrations DRN package Feb 1, 2024
@JoerivanEngelen JoerivanEngelen changed the title Add validation concentrations DRN package Validation concentrations missing in some packages Feb 1, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Feb 1, 2024
@JoerivanEngelen JoerivanEngelen self-assigned this Feb 2, 2024
@JoerivanEngelen JoerivanEngelen moved this from 🤝 Accepted to 🏗 In Progress in iMOD Suite Feb 2, 2024
@JoerivanEngelen JoerivanEngelen mentioned this issue Feb 2, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 5, 2024
@JoerivanEngelen
Issue #805 Add missing validation concentrations (#808)
c1e6c82 
Fixes #805 

# Description
Validation of concentrations was missing for the DRN, WEL, and EVT
package. This PR:
* Adds validation schemata to the DRN and EVT
* Adds ``AnyNodataSchema``
* Validate if ``Well`` has no nodata for certain variables.

I was struggling a bit with the linting/formatting it appears that we
are running both ``black `` as well as ``ruff`` which causes changes.

# Checklist
<!---
Before requesting review, please go through this checklist:
-->

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in iMOD Suite Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #805 Add missing validation concentrations Deltares/imod-python
1 participant
@JoerivanEngelen