Issue #805 Add missing validation concentrations #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manangka
approved these changes
Feb 2, 2024
luitjansl
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
looks good. Still, there may be a case for some additional validation on a higher level: do the flow boundaries have data on the concentration species that are being transported by the transport model? What if the transport model transports 1 species but the flow packages have data on 2 species? or what if the flow packages have data on 1 species, but it's not the species that the transport model transports?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805
Description
Validation of concentrations was missing for the DRN, WEL, and EVT package. This PR:
AnyNodataSchemaWellhas no nodata for certain variables.I was struggling a bit with the linting/formatting it appears that we are running both
blackas well asruffwhich causes changes.Checklist
Issue #nr, e.g.Issue #737