-
Notifications
You must be signed in to change notification settings - Fork 1.9k
UT: Add streambuffer test to make PR #391 pass #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarg
reviewed
Oct 15, 2021
aggarg
reviewed
Oct 15, 2021
archigup
previously approved these changes
Oct 15, 2021
aggarg
reviewed
Oct 15, 2021
FreeRTOS/Test/CMock/message_buffer/size_mismatch/message_buffer_utest.c
Outdated
Show resolved
Hide resolved
aggarg
previously approved these changes
Oct 15, 2021
archigup
reviewed
Oct 15, 2021
| * @brief Dummy sender task handle to which the stream buffer receive APIs will send notification. | ||
| */ | ||
| //static TaskHandle_t senderTask = ( TaskHandle_t ) ( 0xAABBCCDD ); | ||
| /*static TaskHandle_t senderTask = ( TaskHandle_t ) ( 0xAABBCCDD ); */ |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these commented out variables just be removed?
aggarg
approved these changes
Oct 15, 2021
aggarg
added a commit
that referenced
this pull request
Nov 12, 2021
aggarg
added a commit
to aggarg/FreeRTOS
that referenced
this pull request
Nov 13, 2021
FreeRTOS#690)"" This reverts commit 7340a72.
aggarg
added a commit
that referenced
this pull request
Nov 15, 2021
johnrhen
pushed a commit
to johnrhen/FreeRTOS
that referenced
this pull request
Nov 24, 2021
FreeRTOS#690)"" This reverts commit 7340a72.
abhidixi11
pushed a commit
that referenced
this pull request
Dec 16, 2021
* Bring FreeRTOS-Kernel submodule pointer to V10.4.6 Signed-off-by: Gaurav Aggarwal <[email protected]> * Remove C89 flag from tests Signed-off-by: Gaurav Aggarwal <[email protected]> * Revert "UT: Add streambuffer test to make PR #391 pass (#690)" This reverts commit a861781.
moninom1
pushed a commit
to moninom1/FreeRTOS
that referenced
this pull request
Apr 17, 2023
* wip * fix build failure and test failures for FreeRTOS IP unit tests * new ip diffconfig 1 included in build * updating prvProcessUDPPacket() as per PR FreeRTOS#689 and fixing tests * wip ip diffconfig * added diffconfig2 for ip unit tests wrt to diffconfig with ipconfigCOMPATIBLE_WITH_SINGLE set as zero to enable FreeRTOS_IP_init tests and fixed freertos ip diffconfig unit tests * minor fix on an ARP unit test * minor fix with ip utils diffconfig unit tests build * Fixed build failure with ip diffconfig 1 and 2. Pulled latest changes from dev/v6 branch. * Removed unused code.
urutva
pushed a commit
to urutva/FreeRTOS
that referenced
this pull request
Aug 29, 2023
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
UT: Add streambuffer test to make PR FreeRTOS#391 pass
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
FreeRTOS#690)"" This reverts commit 38a5e2c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add streambuffer test to make kernel PR #391 pass
Description
kernel PR 391 fails as a new assert is added without UT
FreeRTOS/FreeRTOS-Kernel#391
Test Steps
add an test to check for the assert
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.