Add context manager to Reader and other improvements #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, this PR proposes to add a context manager that makes sure open files are closed properly in the most Pythonic way there is (also see #107).
I've also made some other improvements (at least I think they are ;-), these can be singled out if you don't agree with all of them:
shapefile.POINT
)Reader.close()
I've just started using
pyshp
for shapefile manipulations, thanks for the project! It's so convenient that it's noarch, pure Python and py2/3! ❤️Eventually tests should really be implemented as unit tests, which is not a lot of work when relying on
pytest
,and Travis(ah Travis is set up already) and Appveyor should be set up as CI. I don't have time for this right now but might make a PR for this in the future..Fixes #121