-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: configure blunderbuss #4603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@grant @larkee @GoogleCloudPlatform/storage-dpe @DukeNg @ZiweiZhao Please take a look |
LGTM for `functions` if you add `grant` to the list.
…On Fri, Aug 28, 2020, 2:20 PM Takashi Matsuo ***@***.***> wrote:
@grant <https://github.com/grant> @larkee <https://github.com/larkee>
@GoogleCloudPlatform/storage-dpe
<https://github.com/orgs/GoogleCloudPlatform/teams/storage-dpe> @DukeNg
<https://github.com/dukeng> @ZiweiZhao <https://github.com/ZiweiZhao>
Please take a look
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARTZRN6TH26ZFI26B5EQO3SDANRLANCNFSM4QOQYJ2Q>
.
|
@ace-n Done both for the blunderbuss config and the CODEOWNERS file |
I'll ping reviewers today, and then merge this in a couple of days. |
- 'api: logging' | ||
to: | ||
- simonz130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we autoassign one person (fine if it's me) and also add a team as a subscriber to the bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://github.com/googleapis/repo-automation-bots/tree/master/packages/blunderbuss
Probably not possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you add the team in the CODEOWNER, they'll be subscribed when the bug opens.
LGTM. I have had two new team members start today so I'll probably have another update in a few weeks. |
@kalyanac @jqll @donmccasland @dinagraves @kelsk I modified the config. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please wait for kalyanac's approval.
I think we're good to go now. @telpirion is ooo right now, but I think he's ok with this change. |
No description provided.