Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: configure blunderbuss #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Aug 28, 2020

No description provided.

@tmatsuo tmatsuo requested a review from a team as a code owner August 28, 2020 21:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 28, 2020

@grant @larkee @GoogleCloudPlatform/storage-dpe @DukeNg @ZiweiZhao

Please take a look

@ace-n
Copy link

ace-n commented Aug 28, 2020 via email

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 28, 2020

@ace-n Done both for the blunderbuss config and the CODEOWNERS file

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 29, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 1, 2020

I'll ping reviewers today, and then merge this in a couple of days.

Comment on lines +71 to +75
- 'api: logging'
to:
- simonz130

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we autoassign one person (fine if it's me) and also add a team as a subscriber to the bug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add the team in the CODEOWNER, they'll be subscribed when the bug opens.

@sgreenberg
Copy link
Contributor

LGTM. I have had two new team members start today so I'll probably have another update in a few weeks.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 1, 2020

@kalyanac @jqll @donmccasland @dinagraves @kelsk

I modified the config. PTAL

Copy link
Contributor

@jqll jqll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait for kalyanac's approval.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 1, 2020

I think we're good to go now. @telpirion is ooo right now, but I think he's ok with this change.

@tmatsuo tmatsuo merged commit 19f35d6 into GoogleCloudPlatform:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.