feat: implement PayrollHistory component with enhanced date formatting and i18n #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffredodd
commented
Sep 18, 2025
|
|
||
| renderWithProviders(<ManageSignatories />) | ||
|
|
||
| expect(screen.getByRole('heading')).toHaveTextContent('otherSignatoryTitle') |
There was a problem hiding this comment.
I made some changes to our translation provider and now these keys render as a by product.
jeffredodd
commented
Sep 18, 2025
| @@ -1,27 +1,34 @@ | |||
| import type { ReactElement } from 'react' | |||
| import type React from 'react' | |||
There was a problem hiding this comment.
Changes here should allow all translation files to be loaded into tests w/o issue.
There was a problem hiding this comment.
Pull Request Overview
This PR implements the complete PayrollHistory component with enhanced date formatting and comprehensive i18n support. The implementation includes locale-aware date formatting, dynamic i18n namespace loading in the test environment, and proper integration with the existing payroll management system.
- Implements PayrollHistory component with locale-aware date formatting using
parseDateStringToLocal - Adds comprehensive test coverage for both the main component and presentation layer
- Updates i18n configuration to dynamically load translation namespaces in test environments
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test-utils/renderWithProviders.tsx | Replaces static i18n initialization with dynamic namespace loading using Vite's glob function |
| src/shared/constants.ts | Adds new payroll-related event constants for summary/receipt viewing and cancellation |
| src/i18n/en/payroll.payrollhistory.json | Removes unused engineeringStaff label from translations |
| src/components/Payroll/index.ts | Exports the new PayrollHistory component |
| src/components/Payroll/helpers.ts | Adds utility functions for payroll type and status determination |
| src/components/Payroll/helpers.test.ts | Comprehensive tests for the new utility functions |
| src/components/Payroll/PayrollList/PayrollList.tsx | Refactors to use shared getPayrollType helper function |
| src/components/Payroll/PayrollHistory/PayrollHistoryPresentation.tsx | Implements presentation component with DataView table and time filtering |
| src/components/Payroll/PayrollHistory/PayrollHistoryPresentation.test.tsx | Complete test suite for the presentation component |
| src/components/Payroll/PayrollHistory/PayrollHistory.tsx | Main component with API integration and business logic |
| src/components/Payroll/PayrollHistory/PayrollHistory.test.tsx | Integration tests covering API calls and user interactions |
| src/components/Payroll/PayrollHistory/PayrollHistory.stories.tsx | Updates story imports and data types |
| src/components/Company/DocumentSigner/DocumentList/ManageSignatories.test.tsx | Updates to use renderWithProviders helper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e6a23d0 to
d40a8f7
Compare
…ng and i18n - Add PayrollHistory component with comprehensive test coverage (707 tests passing) - Implement proper date formatting for pay periods (July 16–July 30, 2025) - Format pay dates as readable text (Aug 15, 2025 instead of 2025-08-15) - Add comprehensive i18n namespace loading in test environment - Remove hardcoded placeholder text and styling inconsistencies - Add proper locale-aware date formatting with parseDateStringToLocal - Include PayrollHistory types, stories, and complete API integration - Export PayrollHistory component for partner consumption - Fix i18n test infrastructure to support all translation namespaces
- Change namespace from 'Payroll.PayrollHistory' to 'payroll.payrollhistory' - Rename translation file to match expected format - Fix TypeScript errors in CI build - Maintain same functionality with corrected naming convention
- Rename translation file to Payroll.PayrollHistory.json for correct casing - Update component usage to use 'Payroll.PayrollHistory' namespace - Regenerate TypeScript types with proper interface mapping - All tests passing with correct i18n integration - Fixes CI TypeScript errors while maintaining proper namespace conventions
90d8c5e to
fc27613
Compare
serikjensen
reviewed
Sep 18, 2025
src/components/Payroll/PayrollHistory/PayrollHistoryPresentation.tsx
Outdated
Show resolved
Hide resolved
serikjensen
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Overview
This PR implements the complete PayrollHistory component with enhanced date formatting and comprehensive i18n support.
🔧 Technical Improvements
parseDateStringToLocalScreenshots