This repository was archived by the owner on Sep 18, 2023. It is now read-only.
Persistent mapping for uniform buffers#3
Closed
SaschaWillems wants to merge 7 commits intoKhronosGroup:masterfrom
SaschaWillems:memory_mapping
Closed
Persistent mapping for uniform buffers#3SaschaWillems wants to merge 7 commits intoKhronosGroup:masterfrom SaschaWillems:memory_mapping
SaschaWillems wants to merge 7 commits intoKhronosGroup:masterfrom
SaschaWillems:memory_mapping
Conversation
Replaced it with map-once aka "persistent mapping"
charles-lunarg
approved these changes
Oct 13, 2022
Collaborator
charles-lunarg
left a comment
There was a problem hiding this comment.
Changes look exactly how I'd expect them to.
Collaborator
Author
|
Since this is a minor PR I have submitted it to the official repository: Overv#310 I've seen several people new to Vulkan adopt the old way of mapping and unmapping per frame, and this PR should hopefully stop people from doing that in the future. |
Collaborator
|
Going to close this PR since the main one was merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how the tutorial maps uniform buffers for updating. Instead of mapping and unmapping each frame, they are now mapped once after creation ("persistent mapping").
The PR updates both the tutorial chapter (that talks about ubos) and all code snippets that make use of ubos.