Persistent mapping for uniform buffers#310
Merged
Overv merged 7 commits intoOverv:masterfrom Nov 3, 2022
SaschaWillems:memory_mapping
Merged
Persistent mapping for uniform buffers#310Overv merged 7 commits intoOverv:masterfrom SaschaWillems:memory_mapping
Overv merged 7 commits intoOverv:masterfrom
SaschaWillems:memory_mapping
Conversation
Replaced it with map-once aka "persistent mapping"
Owner
|
Sorry for not reviewing earlier, I was on a holiday. |
Overv
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Updated UBO chapter and removed in-place map and unmap of the ubo Replaced it with map-once aka "persistent mapping" * Fixed index for uniform buffer selection * Update code samples to persistent ubo mapping * Resize vector for mapped uniform buffer pointers * Use calculated buffer size for mapping * Update code samples to persistent ubo mapping * Spelling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how the tutorial maps uniform buffers for updating. Instead of mapping and unmapping each frame, they are now mapped once after creation ("persistent mapping").
The PR updates both the tutorial chapter (that talks about ubos) and all code snippets that make use of ubos.