-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add OpenAI codex provider #5270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n (#10736) Co-authored-by: Roo Code <[email protected]>
🦋 Changeset detectedLatest commit: da9d5e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fd16b51 to
ce427c1
Compare
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)The PR adds several duplicate type definitions that already exist in the file:
These appear to be from an upstream merge and may be intentional, but should be reviewed for cleanup. Files Reviewed (24 files)
|
|
|
||
| Add support for OpenAI Codex subscriptions (thanks Roo) | ||
|
|
||
| - Fix: Reset invalid model selection when using OpenAI Codex provider (PR #10777 by @hannesrudolph) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these PR numbers dont make a lot of sense in our repo, should these be urls?
## Problem PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support but did not include the TypeScript type definition in @kilocode/core-schemas. This causes compilation errors when code attempts to handle openai-codex in switch statements: error TS2678: Type '"openai-codex"' is not comparable to type ... The provider was added to: - cli/src/constants/providers/validation.ts (runtime validation) - cli/src/constants/providers/labels.ts (UI labels) - cli/src/constants/providers/settings.ts (default settings) But missing from: - packages/core-schemas/src/config/provider.ts (TypeScript types) ## Impact Any code using switch/case on provider.provider that includes openai-codex will fail TypeScript compilation. This blocks: - CLI providers API command (needs to map openai-codex model field) - Any future switch-based provider handling logic ## Solution This adds the missing type definition: - Created openAICodexProviderSchema with apiModelId field - Added to providerConfigSchema discriminated union (line 396) - Exported OpenAICodexProviderConfig type (line 442) openai-codex now matches the pattern of openai-native (both use apiModelId). ## Verification Type checking now passes: pnpm check-types # No errors in @kilocode/core-schemas or @kilocode/cli Related: Kilo-Org#5270
## Problem PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support but did not include the TypeScript type definition in @kilocode/core-schemas. This causes compilation errors when code attempts to handle openai-codex in switch statements: error TS2678: Type '"openai-codex"' is not comparable to type ... The provider was added to: - cli/src/constants/providers/validation.ts (runtime validation) - cli/src/constants/providers/labels.ts (UI labels) - cli/src/constants/providers/settings.ts (default settings) But missing from: - packages/core-schemas/src/config/provider.ts (TypeScript types) - cli/src/config/mapper.ts (model field mapping) ## Impact Any code using switch/case on provider.provider that includes openai-codex will fail TypeScript compilation. This blocks: - CLI providers API command (needs to map openai-codex model field) - Any future switch-based provider handling logic ## Solution This adds the missing type definition: - Created openAICodexProviderSchema with apiModelId field - Added to providerConfigSchema discriminated union (line 396) - Exported OpenAICodexProviderConfig type (line 442) - Added openai-codex mapping in CLI provider model handling (apiModelId) openai-codex now matches the pattern of openai-native (both use apiModelId). ## Verification Type checking: pnpm check-types CLI tests: cd cli && pnpm test Related: Kilo-Org#5270
## Problem PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support but did not include the TypeScript type definition in @kilocode/core-schemas. This causes compilation errors when code attempts to handle openai-codex in switch statements: error TS2678: Type '"openai-codex"' is not comparable to type ... The provider was added to: - cli/src/constants/providers/validation.ts (runtime validation) - cli/src/constants/providers/labels.ts (UI labels) - cli/src/constants/providers/settings.ts (default settings) But missing from: - packages/core-schemas/src/config/provider.ts (TypeScript types) - cli/src/config/mapper.ts (model field mapping) ## Impact Any code using switch/case on provider.provider that includes openai-codex will fail TypeScript compilation. This blocks: - CLI providers API command (needs to map openai-codex model field) - Any future switch-based provider handling logic ## Solution This adds the missing type definition: - Created openAICodexProviderSchema with apiModelId field - Added to providerConfigSchema discriminated union (line 396) - Exported OpenAICodexProviderConfig type (line 442) - Added openai-codex mapping in CLI provider model handling (apiModelId) openai-codex now matches the pattern of openai-native (both use apiModelId). ## Verification Type checking: pnpm check-types CLI tests: cd cli && pnpm test Related: Kilo-Org#5270
Add OpenAI codex provider
Add OpenAI codex provider
Add support for OpenAI Codex subscriptions, cherry-picked from Roo