Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kevinvandijk
Copy link
Collaborator

@kevinvandijk kevinvandijk commented Jan 21, 2026

Add support for OpenAI Codex subscriptions, cherry-picked from Roo

  • Fix: Reset invalid model selection when using OpenAI Codex provider (PR #10777 by @hannesrudolph)
  • Add OpenAI - ChatGPT Plus/Pro Provider that gives subscription-based access to Codex models without per-token costs (PR #10736 by @hannesrudolph)

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

🦋 Changeset detected

Latest commit: da9d5e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kilo-code Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinvandijk kevinvandijk marked this pull request as ready for review January 21, 2026 12:44
@kiloconnect
Copy link
Contributor

kiloconnect bot commented Jan 21, 2026

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
src/shared/ExtensionMessage.ts 884 Duplicate IndexingStatus interface missing gitBranch and manifest properties
Other Observations (not in diff)

The PR adds several duplicate type definitions that already exist in the file:

  • Command (line 567) duplicates line 46
  • IndexingStatusUpdateMessage (line 893) duplicates line 76
  • LanguageModelChatSelector (line 898) duplicates line 81
  • WebviewMessage interface duplicates the one in WebviewMessage.ts

These appear to be from an upstream merge and may be intentional, but should be reviewed for cleanup.

Files Reviewed (24 files)
  • .changeset/eight-pots-shout.md - changeset
  • cli/src/constants/providers/labels.ts - provider label added
  • cli/src/constants/providers/models.ts - provider config added
  • cli/src/constants/providers/settings.ts - provider settings added
  • cli/src/constants/providers/validation.ts - validation rules added
  • packages/types/src/provider-settings.ts - schema and types added
  • packages/types/src/providers/index.ts - exports added
  • packages/types/src/providers/openai-codex.ts - new model definitions
  • src/api/index.ts - handler registration
  • src/api/providers/index.ts - export added
  • src/api/providers/openai-codex.ts - new provider implementation
  • src/core/task/Task.ts - minor changes
  • src/core/webview/ClineProvider.ts - auth state added
  • src/core/webview/webviewMessageHandler.ts - sign in/out handlers
  • src/extension.ts - OAuth manager initialization
  • src/integrations/openai-codex/oauth.ts - new OAuth implementation
  • src/shared/ExtensionMessage.ts - 1 issue (duplicate types)
  • src/shared/WebviewMessage.ts - message types added
  • webview-ui/src/components/kilocode/hooks/useProviderModels.ts - models hook
  • webview-ui/src/components/settings/ApiOptions.tsx - provider UI
  • webview-ui/src/components/settings/__tests__/ApiOptions.spec.tsx - tests
  • webview-ui/src/components/settings/__tests__/ApiOptions.provider-filtering.spec.tsx - test fixes
  • webview-ui/src/components/settings/constants.ts - provider constants
  • webview-ui/src/components/settings/providers/OpenAICodex.tsx - new provider component
  • webview-ui/src/components/settings/providers/index.ts - export added
  • webview-ui/src/components/ui/hooks/useSelectedModel.ts - model selection

Fix these issues in Kilo Cloud


Add support for OpenAI Codex subscriptions (thanks Roo)

- Fix: Reset invalid model selection when using OpenAI Codex provider (PR #10777 by @hannesrudolph)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these PR numbers dont make a lot of sense in our repo, should these be urls?

@kevinvandijk kevinvandijk merged commit b502ecf into main Jan 21, 2026
12 checks passed
@kevinvandijk kevinvandijk deleted the add-openai-codex branch January 21, 2026 13:18
@github-actions github-actions bot mentioned this pull request Jan 21, 2026
PeterDaveHello added a commit to PeterDaveHelloKitchen/kilocode that referenced this pull request Jan 22, 2026
## Problem

PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support but did not
include the TypeScript type definition in @kilocode/core-schemas. This causes
compilation errors when code attempts to handle openai-codex in switch statements:

  error TS2678: Type '"openai-codex"' is not comparable to type ...

The provider was added to:
- cli/src/constants/providers/validation.ts (runtime validation)
- cli/src/constants/providers/labels.ts (UI labels)
- cli/src/constants/providers/settings.ts (default settings)

But missing from:
- packages/core-schemas/src/config/provider.ts (TypeScript types)

## Impact

Any code using switch/case on provider.provider that includes openai-codex
will fail TypeScript compilation. This blocks:
- CLI providers API command (needs to map openai-codex model field)
- Any future switch-based provider handling logic

## Solution

This adds the missing type definition:
- Created openAICodexProviderSchema with apiModelId field
- Added to providerConfigSchema discriminated union (line 396)
- Exported OpenAICodexProviderConfig type (line 442)

openai-codex now matches the pattern of openai-native (both use apiModelId).

## Verification

Type checking now passes:
  pnpm check-types  # No errors in @kilocode/core-schemas or @kilocode/cli

Related: Kilo-Org#5270
PeterDaveHello added a commit to PeterDaveHelloKitchen/kilocode that referenced this pull request Jan 23, 2026
## Problem

PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support
but did not include the TypeScript type definition in
@kilocode/core-schemas. This causes compilation errors when code
attempts to handle openai-codex in switch statements:

  error TS2678: Type '"openai-codex"' is not comparable to type ...

The provider was added to:
- cli/src/constants/providers/validation.ts (runtime validation)
- cli/src/constants/providers/labels.ts (UI labels)
- cli/src/constants/providers/settings.ts (default settings)

But missing from:
- packages/core-schemas/src/config/provider.ts (TypeScript types)
- cli/src/config/mapper.ts (model field mapping)

## Impact

Any code using switch/case on provider.provider that includes
openai-codex will fail TypeScript compilation. This blocks:
- CLI providers API command (needs to map openai-codex model field)
- Any future switch-based provider handling logic

## Solution

This adds the missing type definition:
- Created openAICodexProviderSchema with apiModelId field
- Added to providerConfigSchema discriminated union (line 396)
- Exported OpenAICodexProviderConfig type (line 442)
- Added openai-codex mapping in CLI provider model handling
  (apiModelId)

openai-codex now matches the pattern of openai-native (both use
apiModelId).

## Verification

Type checking:
  pnpm check-types

CLI tests:
  cd cli && pnpm test

Related: Kilo-Org#5270
PeterDaveHello added a commit to PeterDaveHelloKitchen/kilocode that referenced this pull request Jan 23, 2026
## Problem

PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support
but did not include the TypeScript type definition in
@kilocode/core-schemas. This causes compilation errors when code
attempts to handle openai-codex in switch statements:

  error TS2678: Type '"openai-codex"' is not comparable to type ...

The provider was added to:
- cli/src/constants/providers/validation.ts (runtime validation)
- cli/src/constants/providers/labels.ts (UI labels)
- cli/src/constants/providers/settings.ts (default settings)

But missing from:
- packages/core-schemas/src/config/provider.ts (TypeScript types)
- cli/src/config/mapper.ts (model field mapping)

## Impact

Any code using switch/case on provider.provider that includes
openai-codex will fail TypeScript compilation. This blocks:
- CLI providers API command (needs to map openai-codex model field)
- Any future switch-based provider handling logic

## Solution

This adds the missing type definition:
- Created openAICodexProviderSchema with apiModelId field
- Added to providerConfigSchema discriminated union (line 396)
- Exported OpenAICodexProviderConfig type (line 442)
- Added openai-codex mapping in CLI provider model handling
  (apiModelId)

openai-codex now matches the pattern of openai-native (both use
apiModelId).

## Verification

Type checking:
  pnpm check-types

CLI tests:
  cd cli && pnpm test

Related: Kilo-Org#5270
maywzh pushed a commit to maywzh/kilocode that referenced this pull request Jan 25, 2026
maywzh pushed a commit to maywzh/kilocode that referenced this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants