-
Notifications
You must be signed in to change notification settings - Fork 86
⭐️ [Refactor] [bun > pnpm] Feature/jss 93 refactor bun pnpm #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ansonhkg
wants to merge
29
commits into
naga
Choose a base branch
from
feature/jss-93-refactor-bun-pnpm
base: naga
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typedoc-theme-hierarchy because it blocked upgrades, and moved typedoc to 0.28.12 for compatibility with TypeScript 5.8+.
… minimal module mapping, dotenvx for envs - Switched Bun TS runner to Node + tsx with dotenvx wrapping for env loading. - Replaced Bun E2E runner with Jest using a dedicated jest e2e config - Resolved CJS/ESM breakages by using Babel transfomer for .ts|.js| in Jest. - Avoided duplicated module resolution: ignored `.nx/` and `dist/` in Jest. - Prevented hijacking external `@lit-protocol/*` and only map local packages
… minimal module mapping, dotenvx for envs - Switched Bun TS runner to Node + tsx with dotenvx wrapping for env loading. - Replaced Bun E2E runner with Jest using a dedicated jest e2e config - Resolved CJS/ESM breakages by using Babel transfomer for .ts|.js| in Jest. - Avoided duplicated module resolution: ignored `.nx/` and `dist/` in Jest. - Prevented hijacking external `@lit-protocol/*` and only map local packages
… only supports `babel-jest@^.29`.
…update reset script in package.json
- ESlint 8.48.0 no longer supported - @walletconnect/ethereum-provider is unused - uuidv4 to `crypto.randomUUID()` `@simplewebauthn/typescript-types` is NOT yet replaced with later types as unsure with side effects, locked-in to a particular version instead.
…s and remove module type; add TypeScript configuration
- remove unused artillery scripts - and update test command in package.json - remove unused packages
- Update type definitions to replace deprecated PKPInfo with PKPData across auth and e2e packages. - Modify Jest configuration to match all spec files in e2e tests. - Add .e2e to .gitignore for better file management. - Enhance e2e package structure with new types and utility functions for improved clarity and maintainability.
- moved inline import to top of the file - migrated to jest syntax - export utils from e2e and consumed by artillery - moved artillery as its own package - migrated script commands
…or better type safety
glitch003
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems pretty straightforward - looks good to me
Draft
…tocol/js-sdk into feature/jss-107-refactor-move-e2e-and-artillery-into-packages
…ve-e2e-and-artillery-into-packages Feature/jss 107 refactor move e2e and artillery into packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
17.3.0
and pinned to21.2.1
0.19.2
to satisfy Nx, removedtypedoc-theme-hierarchy
because it blocked upgrades, and movedtypedoc
to0.28.12
for compatibility with TypeScript 5.8+..env
and run thegen:local-network-context
usingtsx
. PreviouslyBun
would automatically detect and load the.env
file.Do not merge this until these are merged
Based off this branch (pnpm migration)
UPDATE 22/09/2025
Do not merge until loading is done or ✅ from @hwrdtm