-
Notifications
You must be signed in to change notification settings - Fork 86
Feature/jss 107 refactor move e2e and artillery into packages #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Ansonhkg
merged 12 commits into
feature/jss-93-refactor-bun-pnpm
from
feature/jss-107-refactor-move-e2e-and-artillery-into-packages
Sep 18, 2025
Merged
Feature/jss 107 refactor move e2e and artillery into packages #891
Ansonhkg
merged 12 commits into
feature/jss-93-refactor-bun-pnpm
from
feature/jss-107-refactor-move-e2e-and-artillery-into-packages
Sep 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and remove module type; add TypeScript configuration
- remove unused artillery scripts - and update test command in package.json - remove unused packages
- Update type definitions to replace deprecated PKPInfo with PKPData across auth and e2e packages. - Modify Jest configuration to match all spec files in e2e tests. - Add .e2e to .gitignore for better file management. - Enhance e2e package structure with new types and utility functions for improved clarity and maintainability.
- moved inline import to top of the file - migrated to jest syntax - export utils from e2e and consumed by artillery - moved artillery as its own package - migrated script commands
…or better type safety
glitch003
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a straightforward refactor
Draft
…tocol/js-sdk into feature/jss-107-refactor-move-e2e-and-artillery-into-packages
a388b28
into
feature/jss-93-refactor-bun-pnpm
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
./packages/artillery
./packages/e2e
PKPInfo
asPKPData
from@lit-protocol/schemas
. Note that there are probably more types to fix. The duplicate types across different packages existed because I had to resolve multiple circular dependencies during the initial revamp, before the overall structure was established.