Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

brian604
Copy link
Contributor

@brian604 brian604 commented Jan 4, 2025

[Add] Data source
[Add] Examples with and without model use according to @ash-hun comment and @JunseongKim1104 comment in (Original PR) #82

  • Last Modified Date: 2025/01/4 6:30 PM

Copy link
Contributor

@JunseongKim1104 JunseongKim1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review]

Review OS(Windows/Mac/Linux): Win
Template Rule 가이드를 준수 하였는가(YES/NO): YES
Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): YES
import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요): No

window 환경에서 !pip install 다음에 # 으로 주석멘트를 달면 에러가 나는 부분 수정해서 반영 해 두었습니다.

빠르게 업데이트 하시느라 정말 수고 많으셨습니다!

Copy link
Contributor Author

@brian604 brian604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다.
감사합니다, @JunseongKim1104

@teddylee777 teddylee777 merged commit af7df04 into LangChain-OpenTutorial:main Jan 4, 2025
1 check failed
brian604 added a commit to brian604/LangChain-OpenTutorial that referenced this pull request Jan 14, 2025
1. LangChain-OpenTutorial#113
2. LangChain-OpenTutorial#299

All comments have been reflected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants