E-2] 03-OutputParser / 05- PandasDataFrameOutputParser #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Computer: Mac Air Mini (basemodel)
- Did not use LLM API, yet
- Initial Commit
----
Author Checklist
- [ x ] PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
- [ x ] Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
Review Template (Intial PR)
🖥️ OS: Win/Mac/Linux
✅ Checklist
- [ ] **Template**: Tutorials follows the required template.
- [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
- [ ] **Image**: Image filenames follow guidelines.
- [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [ ] **Code Execution**: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
If no one reviews your PR within a few days, please mention one of teddylee777, musangk, BAEM1N (@)
1. LangChain-OpenTutorial#113 2. LangChain-OpenTutorial#299 All comments have been reflected.
chaeyoonyunakim
approved these changes
Jan 18, 2025
|
안녕하세요 @brian604 님, 수정사항이 조금 있어서 코멘트를 남기게 되었습니다. 
반영해서 커밋 해주시면 approve 하겠습니다~! |
|
저 부분은 @teddylee777 님께서 에러에 대한 케이스에 대한 설명이어서요.. 오히려 놔두는게 이득이 될거 같습니다. |
|
pprint는 아직 langchain 패키지에 반영이 되지 않는것 같네요. 패키지 리퀘스트를 날리고 다시 PR을 날려야 할까요? @BokyungisaGod |
|
앗 그런가요 ㅎㅎ 그러면 warning메세지는 따로 수정하지 않아도 됩니당. |
|
pprint 같은 경우는 "Python" 자체에서 default로 제공하는 패키지이네요. 제가 pprintpp 를 다운로드해서 생겨나는 문제인것 같습니다 @BokyungisaGod |
|
확인했습니다:) |
|
@BokyungisaGod 님 approval 완료까지 요청드려요 |
bf8163e
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Past URL
I have closed the PR: #365 and opened this a new one.
Have erased the new content that has been brought up (2025/01/18)
Review Template (After Proofread and Peer Reviews)
I have reflected all the changes, suggested by the PR reviews and issue reviews.
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N