Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

hong-seongmin
Copy link
Contributor

πŸ–₯️ OS: Win
βœ… Checklist

[V] Template: Tutorials follows the required template.
[YES] Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
[V] Image: Image filenames follow guidelines.
[V] *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
[V] Code Execution: Code runs without errors.
Comments:
폴더λͺ… 02-PROMPT => 02-Prompt
! => %
Chroma => Chroma
OpenAIEmbeddings = > OpenAIEmbeddings

λ‹€μ‹œ ν¬ν¬ν•΄μ„œ 파일 λ‹€μ‹œ 올림
@chaeyoonyunakim
Copy link
Contributor

@hong-seongminλ‹˜, 수고 λ§ŽμœΌμ‹­λ‹ˆλ‹€.

02-Prompt/02-FewShotPromptTemplate.ipynb λ²ˆμ—­/감수 μˆ˜μ • 반영 ν™•μΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.
10-Retriever/06-MultiQueryRetriever.ipynb에 λŒ€ν•œ 리뷰 PR을 λ³„λ„λ‘œ λΆ„λ¦¬ν•΄μ£Όμ‹œκ±°λ‚˜ ν˜„μž¬ PRμ—μ„œ 10-06번 λ…ΈνŠΈλΆ λ™λ£Œλ¦¬λ·°λ₯Ό μ§„ν–‰ν•˜μ‹œλ©΄ μ™„λ£Œ ν›„ ν•¨κ»˜ λ¨Έμ§€ν•  수 μžˆμ„ λ“― ν•©λ‹ˆλ‹€.

@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading λ²ˆμ—­/κ²€μˆ˜νŒ€ μ œμ•ˆμ‚¬ν•­ 반영 make a change on existing file labels Jan 6, 2025
기본적인 μˆ˜μ • μ™„λ£Œ
Copy link
Contributor

@sirena1 sirena1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS:

    • Windows
  • Template Rule μ€€μˆ˜ μ—¬λΆ€:

    • Template Rule κ°€μ΄λ“œλ₯Ό μ€€μˆ˜ν•˜μ˜€λŠ”κ°€? (Check ν‘œκΈ°)
  • Table of Contents 링크 확인:

    • Table of Contents의 링크가 μ›ν™œν•˜κ²Œ λ™μž‘ν•˜λŠ”μ§€ ν™•μΈν•˜μ˜€λŠ”κ°€? (Check ν‘œκΈ°)
  • 이미지 파일λͺ… κ²€ν† :

    • 이미지가 ν¬ν•¨λ˜μ–΄ μžˆλ‹€λ©΄, μ΄λ―Έμ§€μ˜ 파일λͺ…이 κ°€μ΄λ“œλ₯Ό μ€€μˆ˜ν•˜μ˜€λŠ”κ°€? (Check ν‘œκΈ°)
  • μ΅œμ‹  import 방식 μ‚¬μš© μ—¬λΆ€:

    • import ꡬ문이 μ˜ˆμ „ legacy 방식이 μ•„λ‹Œ μ΅œμ‹  버전을 λ”°λ₯΄λŠ”κ°€? (Check ν‘œκΈ°)
  • μ½”λ“œ λ™μž‘ 확인:

    • λͺ¨λ“  μ½”λ“œκ°€ 였λ₯˜ 없이 λ™μž‘ν•˜λŠ”κ°€? (Check ν‘œκΈ°)
    • Warning λ°œμƒ μ‹œ μ½”λ©˜νŠΈμ— μ μ–΄μ£Όμ„Έμš”.
  • 제좜 파일 확인:

    • κΌ­ ν•„μš”ν•œ νŒŒμΌλ“€λ§Œ μ œμΆœλ˜μ—ˆλŠ”κ°€?
      • νŠœν† λ¦¬μ–Ό μ™Έ μ„€μ • νŒŒμΌμ΄λ‚˜ λ‹€λ₯Έ 뢄이 μž‘μ—…ν•œ 파일이 ν¬ν•¨λ˜μ—ˆλŠ”μ§€ Files Changedμ—μ„œ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€. (Check ν‘œκΈ°)
  • 기타 의견:
    Files Changed에 이전 파일인 02-Prompt/02-FewShotPromptTemplate.ipynb κ°€ ν•¨κ»˜ ν¬ν•¨λ˜μ–΄ μžˆμœΌλ‚˜,
    같은 PR둜 μƒμ„±λ˜μ–΄ 10-Retriever/06-MultiQueryRetriever.ipynb 에 λŒ€ν•œ 리뷰 μ§„ν–‰ μ™„λ£Œν•˜μ˜€μŠ΅λ‹ˆλ‹€.

sirena1
sirena1 previously approved these changes Jan 7, 2025
peer reviewμˆ˜μ •
Copy link
Contributor

@jeong-wooseok jeong-wooseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review]

  1. Review OS:Windows
  2. Template Rule κ°€μ΄λ“œλ₯Ό μ€€μˆ˜ ν•˜μ˜€λŠ”κ°€:YES
  3. Table of Contents 의 링크가 μ›ν™œν•˜κ²Œ λ™μž‘ν•˜λŠ”μ§€ ν™•μΈν•˜μ˜€λŠ”κ°€?:YES
  4. 이미지가 ν¬ν•¨λ˜μ–΄ μžˆλ‹€λ©΄, μ΄λ―Έμ§€μ˜ 파일λͺ…이 κ°€μ΄λ“œλ₯Ό μ€€μˆ˜ν•˜μ˜€λŠ”κ°€?:YES
  5. import ꡬ문이 μ˜ˆμ „ legacy 방식이 μ•„λ‹Œ μ΅œμ‹  버전을 λ”°λ₯΄λŠ”κ°€?(YES/NO):YES
  6. λͺ¨λ“  μ½”λ“œκ°€ λ™μž‘μ— 였λ₯˜ 없이 λ™μž‘ν•˜λŠ”κ°€? (λ§Œμ•½, warning λ°œμƒμ‹œ μ½”λ©˜νŠΈμ— μ μ–΄μ£Όμ„Έμš”):YES
  7. κΌ­ ν•„μš”ν•œ νŒŒμΌλ“€λ§Œ 제좜 λ˜μ—ˆλŠ”κ°€? νŠœν† λ¦¬μ–Ό μ™Έ μ„€μ • νŒŒμΌμ΄λ‚˜ λ‹€λ₯Έ 뢄이 μž‘μ—…ν•œ 파일이 ν¬ν•¨λ˜μ—ˆλŠ”μ§€
    Files Changed μ—μ„œ 확인 뢀탁 λ“œλ¦½λ‹ˆλ‹€.:YES
  8. 기타 의견:
  • 확인 μ™„λ£Œν•˜μ˜€μŠ΅λ‹ˆλ‹€. κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€.

@hong-seongmin hong-seongmin requested a review from sirena1 January 8, 2025 12:00
Copy link
Contributor

@jhboyo jhboyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review]

  1. Review OS: Mac
  2. Template Rule κ°€μ΄λ“œλ₯Ό μ€€μˆ˜ ν•˜μ˜€λŠ”κ°€:YES
  3. Table of Contents 의 링크가 μ›ν™œν•˜κ²Œ λ™μž‘ν•˜λŠ”μ§€ ν™•μΈν•˜μ˜€λŠ”κ°€?:YES
  4. 이미지가 ν¬ν•¨λ˜μ–΄ μžˆλ‹€λ©΄, μ΄λ―Έμ§€μ˜ 파일λͺ…이 κ°€μ΄λ“œλ₯Ό μ€€μˆ˜ν•˜μ˜€λŠ”κ°€?: N/A
  5. import ꡬ문이 μ˜ˆμ „ legacy 방식이 μ•„λ‹Œ μ΅œμ‹  버전을 λ”°λ₯΄λŠ”κ°€?(YES/NO):YES
  6. λͺ¨λ“  μ½”λ“œκ°€ λ™μž‘μ— 였λ₯˜ 없이 λ™μž‘ν•˜λŠ”κ°€? (λ§Œμ•½, warning λ°œμƒμ‹œ μ½”λ©˜νŠΈμ— μ μ–΄μ£Όμ„Έμš”):YES
  7. κΌ­ ν•„μš”ν•œ νŒŒμΌλ“€λ§Œ 제좜 λ˜μ—ˆλŠ”κ°€? νŠœν† λ¦¬μ–Ό μ™Έ μ„€μ • νŒŒμΌμ΄λ‚˜ λ‹€λ₯Έ 뢄이 μž‘μ—…ν•œ 파일이 ν¬ν•¨λ˜μ—ˆλŠ”μ§€ Files Changed μ—μ„œ 확인 뢀탁 λ“œλ¦½λ‹ˆλ‹€.:YES
  8. 기타 의견: μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!

@teddylee777 teddylee777 merged commit 193f9e4 into LangChain-OpenTutorial:main Jan 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs tutorial proofreading λ²ˆμ—­/κ²€μˆ˜νŒ€ μ œμ•ˆμ‚¬ν•­ 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants