-
Notifications
You must be signed in to change notification settings - Fork 282
[E-1] 02-Prompt / 02-FewShotPromptTemplate.ipynb #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
λ€μ ν¬ν¬ν΄μ νμΌ λ€μ μ¬λ¦Ό
@hong-seongminλ, μκ³ λ§μΌμλλ€.
|
κΈ°λ³Έμ μΈ μμ μλ£
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Review Checklist]
-
Review OS:
- Windows
-
Template Rule μ€μ μ¬λΆ:
- Template Rule κ°μ΄λλ₯Ό μ€μνμλκ°? (Check νκΈ°)
-
Table of Contents λ§ν¬ νμΈ:
- Table of Contentsμ λ§ν¬κ° μννκ² λμνλμ§ νμΈνμλκ°? (Check νκΈ°)
-
μ΄λ―Έμ§ νμΌλͺ κ²ν :
- μ΄λ―Έμ§κ° ν¬ν¨λμ΄ μλ€λ©΄, μ΄λ―Έμ§μ νμΌλͺ μ΄ κ°μ΄λλ₯Ό μ€μνμλκ°? (Check νκΈ°)
-
μ΅μ import λ°©μ μ¬μ© μ¬λΆ:
- import κ΅¬λ¬Έμ΄ μμ legacy λ°©μμ΄ μλ μ΅μ λ²μ μ λ°λ₯΄λκ°? (Check νκΈ°)
-
μ½λ λμ νμΈ:
- λͺ¨λ μ½λκ° μ€λ₯ μμ΄ λμνλκ°? (Check νκΈ°)
- Warning λ°μ μ μ½λ©νΈμ μ μ΄μ£ΌμΈμ.
-
μ μΆ νμΌ νμΈ:
- κΌ νμν νμΌλ€λ§ μ μΆλμλκ°?
- νν λ¦¬μΌ μΈ μ€μ νμΌμ΄λ λ€λ₯Έ λΆμ΄ μμ ν νμΌμ΄ ν¬ν¨λμλμ§ Files Changedμμ νμΈ λΆνλ립λλ€. (Check νκΈ°)
- κΌ νμν νμΌλ€λ§ μ μΆλμλκ°?
-
κΈ°ν μ견:
Files Changedμ μ΄μ νμΌμΈ 02-Prompt/02-FewShotPromptTemplate.ipynb κ° ν¨κ» ν¬ν¨λμ΄ μμΌλ,
κ°μ PRλ‘ μμ±λμ΄ 10-Retriever/06-MultiQueryRetriever.ipynb μ λν 리뷰 μ§ν μλ£νμμ΅λλ€.
peer reviewμμ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Review]
- Review OS:Windows
- Template Rule κ°μ΄λλ₯Ό μ€μ νμλκ°:YES
- Table of Contents μ λ§ν¬κ° μννκ² λμνλμ§ νμΈνμλκ°?:YES
- μ΄λ―Έμ§κ° ν¬ν¨λμ΄ μλ€λ©΄, μ΄λ―Έμ§μ νμΌλͺ μ΄ κ°μ΄λλ₯Ό μ€μνμλκ°?:YES
- import κ΅¬λ¬Έμ΄ μμ legacy λ°©μμ΄ μλ μ΅μ λ²μ μ λ°λ₯΄λκ°?(YES/NO):YES
- λͺ¨λ μ½λκ° λμμ μ€λ₯ μμ΄ λμνλκ°? (λ§μ½, warning λ°μμ μ½λ©νΈμ μ μ΄μ£ΌμΈμ):YES
- κΌ νμν νμΌλ€λ§ μ μΆ λμλκ°? νν λ¦¬μΌ μΈ μ€μ νμΌμ΄λ λ€λ₯Έ λΆμ΄ μμ
ν νμΌμ΄ ν¬ν¨λμλμ§
Files Changed μμ νμΈ λΆν λ립λλ€.:YES - κΈ°ν μ견:
- νμΈ μλ£νμμ΅λλ€. κ³ μνμ ¨μ΅λλ€.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Review]
- Review OS: Mac
- Template Rule κ°μ΄λλ₯Ό μ€μ νμλκ°:YES
- Table of Contents μ λ§ν¬κ° μννκ² λμνλμ§ νμΈνμλκ°?:YES
- μ΄λ―Έμ§κ° ν¬ν¨λμ΄ μλ€λ©΄, μ΄λ―Έμ§μ νμΌλͺ μ΄ κ°μ΄λλ₯Ό μ€μνμλκ°?: N/A
- import κ΅¬λ¬Έμ΄ μμ legacy λ°©μμ΄ μλ μ΅μ λ²μ μ λ°λ₯΄λκ°?(YES/NO):YES
- λͺ¨λ μ½λκ° λμμ μ€λ₯ μμ΄ λμνλκ°? (λ§μ½, warning λ°μμ μ½λ©νΈμ μ μ΄μ£ΌμΈμ):YES
- κΌ νμν νμΌλ€λ§ μ μΆ λμλκ°? νν λ¦¬μΌ μΈ μ€μ νμΌμ΄λ λ€λ₯Έ λΆμ΄ μμ ν νμΌμ΄ ν¬ν¨λμλμ§ Files Changed μμ νμΈ λΆν λ립λλ€.:YES
- κΈ°ν μ견: μκ³ νμ ¨μ΅λλ€!
193f9e4
into
LangChain-OpenTutorial:main
π₯οΈ OS: Win
β Checklist
[V] Template: Tutorials follows the required template.
[YES] Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
[V] Image: Image filenames follow guidelines.
[V] *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
[V] Code Execution: Code runs without errors.
Comments:
ν΄λλͺ 02-PROMPT => 02-Prompt
! => %
Chroma => Chroma
OpenAIEmbeddings = > OpenAIEmbeddings