Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Jan 24, 2025

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: Proofread: < 16-Evaluations / 02-Evaluation-using-RAGAS > #538

    • backtick, bold 앞 뒤로 공백처리
    • 이전 튜토리얼 링크 삭제
    • 수식 변수 inline 수식 처리
    • batch dataset과 batch_dataset 구분
    • heading에 있는 모듈 이름에 backtick 처리
    • [gitbook] 수식이 가운데 정렬되지 않는 이슈 -> <p align="center"> </p> 추가
    • [gitbook] inline 수식의 경우 gitbook에서 처리되지 않고 있음
  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@sungchul2 sungchul2 self-assigned this Jan 24, 2025
@sungchul2
Copy link
Contributor Author

@kkam-dragon @BokyungisaGod
#538 (comment) 이 코멘트 확인해주시면 감사하겠습니다 :)

kkam-dragon
kkam-dragon previously approved these changes Jan 24, 2025
Copy link
Contributor

@kkam-dragon kkam-dragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlatjcj 님~
의견주신 내용 확인 했고, 댓글 달아 놨습니다.

수고하셨어요!!

@chaeyoonyunakim chaeyoonyunakim added the proofreading 번역/검수팀 제안사항 반영 label Jan 24, 2025
- Enhanced the RAGAS evaluation notebook with comprehensive metrics calculation
- Added code to save evaluation results to CSV
- Improved markdown formatting for mathematical equations
- Refined dataset processing and evaluation steps
@sungchul2 sungchul2 requested a review from kkam-dragon January 31, 2025 06:43
@sungchul2 sungchul2 marked this pull request as ready for review January 31, 2025 06:43
Copy link
Contributor

@kkam-dragon kkam-dragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)

@kkam-dragon kkam-dragon closed this Feb 5, 2025
@sungchul2
Copy link
Contributor Author

@kkam-dragon 이 PR 아직 merge가 안되었는데 왜 닫으셨나요?????

@kkam-dragon kkam-dragon reopened this Feb 5, 2025
@teddylee777 teddylee777 merged commit 4475f19 into LangChain-OpenTutorial:main Feb 7, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants