-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
You may want to use the build tag for new wheels build on an already-released version. CFFI recently discovered this feature and is using it on PyPI to update wheels without changing the version due to the recent problems with patchelf and arm64. You can rename the wheel file after creating it and before pushing to PyPI, with no internal changes needed. This would clearly indicate that the Python3.9 wheels were built from a different process than the other ones. |
This was just to check for the presence of Python 3.9, not for releasing wheels. |
Any progress? FYI, cibuildwheel has supported Python 3.9 on all CI services including Azure since the betas. :) |
We produce nightly wheels for manylinux2010, this PR was just to track when cached versions became available. The current schedule looks like Mac tomorrow and Windows next week. |
As far as I know, multibuild supports Python 3.9 from a day or so after the
release, as well.
|
The manylinux builds all work except for the 32 bit manylinux1 builds that have an unrelated problem on master. Mac and Windows are what we are waiting on. We could do it now with github/actions, or we can wait a bit until it shows up in the usual places. We should be ready to go sometime next week.We are building on Azure which has changed the workflow somewhat. |
Are the Mac builds not working on multibuild? I thought the patch for 3.9
went in on the day of the release?
https://github.com/matthew-brett/multibuild/pull/359
|
That might help for posix, let's see if an update helps. I don't think it will make a difference on windows. |
Apparently not, at least the way we are running the builds on azure. |
Sorry - I'm out of the loop on Windows. But the multibuild appveyor
`install_python.ps1` script works fine for Python 3.9 ...
|
We don't use appveyor. We could use github actions with azure, but things will settle on that front soon enough. I was curious how things would go with this transition and it looks like two weeks. I expect things will go faster when Python 3.10 is released and we could try github actions if there is more delay. |
Looks like 3.9 has arrived on azure ubuntu. We didn't need it for the manylinux builds, but it went in on schedule. |
Still no 3.9 on windows :( |
This is waaaay too long to be without Numpy wheels. Would it be very hard at this stage to resurrect an Appveyor config to build them? |
@matthew-brett Python 3.9 should be available on Windows sometime tomorrow, if all goes well I will do a release Wednesday. There is also a potential fix for the Windows 2004 problem with the new OpenBLAS that was merged to master today. |
Maybe try restarting the CI? The rollout progress is nearing completion: And I had a Windows/3.9 build now pass on another repo: |
The Windows build succeeds and tests run, but the |
The error is
Stack overflow suggests this may be due to the |
It seems to have worked for other Python versions in the most recent nightly. |
Looking at one of the successful runs, a compilation command line is
The output file name starts with |
Let's give it another shot and see if it remains a problem. I don't know if this is a Python 3.9 problem or something added on by Windows. |
Hmm, the failed test uses |
There seems to be a problem with where distutils creates its temp files when building. CPython 3.8 puts the output here
but 3.9 is putting it here, note that the path is duplicated. So it is close to the MAX_PATH character limit
Apparently you can change the limit with |
That didn't work. I've cleaned up and rebased on master to continue experiments. |
For the 1.19.3 release, I'd be happy to skip those failing tests on Python 3.9. |
probably wise to skip them and get this over with |
I've done that for the 1.19.x branch. I wonder if it is a pytest bug that might be fixed on later releases. We are pinned to an older version because of the hypothesis problem. |
Looks to be fixed in master, so closing. |
Not sure if relevant, but the mention of pytest brings to mind this bug with long parametrized IDs: |
No description provided.