TST: simplify source path names in compilation test #17658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xref failing 3.9 builds MacPython/numpy-wheels#101 |
|
I added a Python 3.9 build to Windows so that we can see if this works. |
|
That works, so putting this in, travisCI is still missing the fjords. Thanks Matti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
distutils/_msvccompiler.object_filenames, the source's filename is repeated into thetempdirectory, so if the source file isa/b/c/d/e/f/source.cthat whole hierarchy will be repeated intotemp-platformname, unless thestrip_dirargument is not False. When we run the tests, the starting directory is already quite long on windows, it might be something likeC:\Users\VssAdministrator\AppData\Local\Temp\pytest-of-VssAdministrator\pytest-0\test_cython0\random\_examples\cython, so the final output directory isC:\Users\VssAdministrator\AppData\Local\Temp\pytest-of-VssAdministrator\pytest-0\test_cython0\random\_examples\cython\build\temp.win-amd64-3.9\Release\Users\VssAdministrator\AppData\Local\Temp\pytest-of-VssAdministrator\pytest-0\test_cython0\random\_examples\cython.I think this is too long for windows to handle. I propose to shorten the source file name, so it will not include the full path.