Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

epitka
Copy link

@epitka epitka commented Mar 8, 2024

Fix for #1776

@AArnott AArnott requested a review from neuecc March 14, 2024 12:44
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neuecc I'm not familiar with the changed code. Would you mind taking a look?

@epitka
Copy link
Author

epitka commented Mar 14, 2024

I can give some context too. It seems that original intent was to determine if there were more than 1 candidate for property. This would be the case when property is overridden with a "new" keyword. Since it collects members ignoring case, this falsely flags case when backing field matches property name such as myProp/MyProp.

@epitka
Copy link
Author

epitka commented Mar 21, 2024

Any chance of somebody taking a look at it?

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added explanation. I'll take it.

@AArnott AArnott enabled auto-merge March 31, 2024 22:19
@AArnott AArnott merged commit 43f1b1c into MessagePack-CSharp:master Mar 31, 2024
@epitka-sg
Copy link
Contributor

@AArnott How do I get a hold of package that has this fix merged in? Latest released is 2.5.140?

@AArnott AArnott added this to the v2.5 milestone Jun 6, 2024
@AArnott
Copy link
Collaborator

AArnott commented Jun 6, 2024

Watch for 2.5.168 to appear on nuget.org in the next few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants