Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

versile2
Copy link
Contributor

@versile2 versile2 commented Oct 27, 2024

Description

Fixes regression issue in #10089
Added logic to handle the other popover scenario

  • when not a child of a popover but a child of a higher z-index non-popover

Reimplemented data-ticks, commented out the z-index placement here and got rid of my line skipping this portion.

  • Data-Ticks cause the position updates to happen

How Has This Been Tested?

Visual tests in first comment

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 27, 2024
@versile2
Copy link
Contributor Author

PopoverBugFixofBugFix

@versile2
Copy link
Contributor Author

versile2 commented Oct 27, 2024

Hold on until I do another commit. Found another issue and fixing it too.

@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 27, 2024

@versile2 u can now update your branch and get the UnitTests.Viewer improvements. Either rebase or use "update branch" below.

… when scrolling if the popover would be not visible because it's fully scrolled out of view.

Also fixed null coalescing issue.
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (fb91812) to head (a21b27c).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10106      +/-   ##
==========================================
- Coverage   91.18%   91.18%   -0.01%     
==========================================
  Files         411      411              
  Lines       12483    12483              
  Branches     2429     2429              
==========================================
- Hits        11383    11382       -1     
  Misses        557      557              
- Partials      543      544       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@versile2
Copy link
Contributor Author

All good now, repositioned popovers were continuing when it would be scrolled off screen.

@henon henon changed the title Fix Popover Regression Direction and Location and z-index MudPopover: Fix regression direction and location and z-index Oct 27, 2024
@henon henon changed the title MudPopover: Fix regression direction and location and z-index MudPopover: Fix regression with respect to direction and location and z-index Oct 27, 2024
Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScarletKuro feel free to merge

Copy link
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@versile2
Copy link
Contributor Author

versile2 commented Oct 27, 2024

Seeing this on the Select examples

https://mudblazor.com/components/select#multiselect-customized-selection-text

looking, were there any changes to select besides my popover changes? I'm not saying they didn't but mine should not have caused this type of action (in my testing this is similar to what happens when two popoverproviders that don't error out).

@danielchalmers
Copy link
Member

Seeing this on the Select examples

https://mudblazor.com/components/select#multiselect-customized-selection-text

looking, were there any changes to select besides my popover changes? I'm not saying they didn't but mine should not have caused this type of action (in my testing this is similar to what happens when two popoverproviders that don't error out).

There was #10071 but it worked as of that PR

@danielchalmers
Copy link
Member

Unable to interact with the the docs search results since #10089 on my end and appears to still be an issue with this PR at the moment

video6.mp4

@versile2
Copy link
Contributor Author

Seeing this on the Select examples

https://mudblazor.com/components/select#multiselect-customized-selection-text

looking, were there any changes to select besides my popover changes? I'm not saying they didn't but mine should not have caused this type of action (in my testing this is similar to what happens when two popoverproviders that don't error out).

There was #10071 but it worked as of that PR

It works fine for me? Also I've narrowed down the oddity only to mudselects with an AnchorOrigin set to Bottom Center where Transform Origin isn't set. I will get back to it when I get back.

@ScarletKuro
Copy link
Member

There was #10071 but it worked as of that PR

It works fine for me? Also I've narrowed down the oddity only to mudselects with an AnchorOrigin set to Bottom Center where Transform Origin isn't set. I will get back to it when I get back.

I'm not sure the select was indeed broken by the #10089
I'm still in process of git bisect, I will let ya all know what commit broke it 100%

@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 28, 2024

@danielchalmers was your commit "Inputs, Menu: Standardize default origin point (#10071)" that broke it.
Bisect showed that, and then I double checked by manually reverting your commit from the current head and checked that it fixes it, then i returned your commit and it's broken.

@versile2 pls do not work on the select problem from the popover perspective, as @danielchalmers probably has to fix it.

@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 28, 2024

Unable to interact with the the docs search results since #10089 on my end and appears to still be an issue with this PR at the moment

Working for me with #10089, didn't check it with this commit yet.

upd: yea I have no problem with interacting the menu like on the video even with this PR

@versile2
Copy link
Contributor Author

Just for the record as I think about it I believe @danielchalmers actually fixed something someone had broken and these examples are set manually to bottom center. Which is exactly what's happening it's opening bottom center.

@danielchalmers
Copy link
Member

danielchalmers commented Oct 28, 2024

Just for the record as I think about it I believe @danielchalmers actually fixed something someone had broken and these examples are set manually to bottom center. Which is exactly what's happening it's opening bottom center.

That makes sense. I'll update the examples

@versile2
Copy link
Contributor Author

Just to confirm I don't need to do anything else with this correct?

@danielchalmers
Copy link
Member

Tried again, still unable to interact with autocomplete popovers. Tested in the Wasm project and the test viewer

#10106 (comment)

@versile2
Copy link
Contributor Author

I'm not having any issues, to my knowledge the others aren't either? Your video didn't show up so I can't see from that.
I may be in the dark here, but if you can point me into something I can look into it I'll work on fixing it.

image

Copy link
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, weird. It's working on my other computer so I'll just approve it if it's working for everyone else. Will have to figure out what's up with my desktop!

@danielchalmers
Copy link
Member

@ScarletKuro feel free to merge

@henon @ScarletKuro I'll merge it as everyone seems satisfied

@danielchalmers danielchalmers merged commit c7b0008 into MudBlazor:dev Oct 28, 2024
4 checks passed
@ScarletKuro
Copy link
Member

Wow, weird. It's working on my other computer so I'll just approve it if it's working for everyone else. Will have to figure out what's up with my desktop!

Have you tried to clean build + incognito + different browser? Little worried it doesn't work on your PC

@danielchalmers
Copy link
Member

Wow, weird. It's working on my other computer so I'll just approve it if it's working for everyone else. Will have to figure out what's up with my desktop!

Have you tried to clean build + incognito + different browser? Little worried it doesn't work on your PC

Clearing build, cache, etc did the trick

@versile2 versile2 deleted the fix/popover10089 branch October 30, 2024 17:58
versile2 added a commit to versile2/MudBlazor that referenced this pull request Oct 31, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior or functionality not working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants