-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MudPopover: Fix regression with respect to direction and location and z-index #10106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added 2nd global option for popover placement inside children
Hold on until I do another commit. Found another issue and fixing it too. |
@versile2 u can now update your branch and get the |
… when scrolling if the popover would be not visible because it's fully scrolled out of view. Also fixed null coalescing issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10106 +/- ##
==========================================
- Coverage 91.18% 91.18% -0.01%
==========================================
Files 411 411
Lines 12483 12483
Branches 2429 2429
==========================================
- Hits 11383 11382 -1
Misses 557 557
- Partials 543 544 +1 ☔ View full report in Codecov by Sentry. |
All good now, repositioned popovers were continuing when it would be scrolled off screen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScarletKuro feel free to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this on the Select examples
https://mudblazor.com/components/select#multiselect-customized-selection-text
looking, were there any changes to select besides my popover changes? I'm not saying they didn't but mine should not have caused this type of action (in my testing this is similar to what happens when two popoverproviders that don't error out). |
There was #10071 but it worked as of that PR |
Unable to interact with the the docs search results since #10089 on my end and appears to still be an issue with this PR at the moment video6.mp4 |
It works fine for me? Also I've narrowed down the oddity only to mudselects with an AnchorOrigin set to Bottom Center where Transform Origin isn't set. I will get back to it when I get back. |
I'm not sure the select was indeed broken by the #10089 |
@danielchalmers was your commit "Inputs, Menu: Standardize default origin point (#10071)" that broke it. @versile2 pls do not work on the select problem from the popover perspective, as @danielchalmers probably has to fix it. |
Just for the record as I think about it I believe @danielchalmers actually fixed something someone had broken and these examples are set manually to bottom center. Which is exactly what's happening it's opening bottom center. |
That makes sense. I'll update the examples |
Just to confirm I don't need to do anything else with this correct? |
Tried again, still unable to interact with autocomplete popovers. Tested in the Wasm project and the test viewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, weird. It's working on my other computer so I'll just approve it if it's working for everyone else. Will have to figure out what's up with my desktop!
@henon @ScarletKuro I'll merge it as everyone seems satisfied |
Have you tried to clean build + incognito + different browser? Little worried it doesn't work on your PC |
Clearing build, cache, etc did the trick |
Description
Fixes regression issue in #10089
Added logic to handle the other popover scenario
Reimplemented data-ticks, commented out the z-index placement here and got rid of my line skipping this portion.
How Has This Been Tested?
Visual tests in first comment
Type of Changes
Checklist
dev
).