Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MudCheckBox: Change disabled text color #11263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

MudCheckBox: Change disabled text color #11263

wants to merge 1 commit into from

Conversation

boukenka
Copy link
Contributor

@boukenka boukenka commented Apr 30, 2025 •
edited
Loading

Description

When the MudCheckBox has the Disabled status, the text of the MudCheckBox has not the disabled text Color. It is not consistent for example with the same type of style applied to MudRadio.

How Has This Been Tested?

This has only been tested visually. Only one css property has been modified.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Here's an example of the change in comparison with MudRadio.

Change

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement New feature or request PR: needs review labels Apr 30, 2025
@boukenka boukenka changed the title MudCheckBox : Disabled text color update MudCheckBox : Change disabled text color Apr 30, 2025
@boukenka
Copy link
Contributor Author

boukenka commented Apr 30, 2025 •
edited
Loading

Test failing because Expected picker.Instance.Date to be <2025-03-23>, but found <2025-02-23>.
Seems to be a culture problem? I fail to see the logic or reason for this error with the proposed PR.

@Anu6is Anu6is mentioned this pull request Apr 30, 2025
Merged
3 tasks
@boukenka boukenka marked this pull request as draft May 1, 2025 07:53
@boukenka boukenka marked this pull request as ready for review May 1, 2025 07:54
@boukenka boukenka closed this May 1, 2025
@boukenka boukenka reopened this May 1, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@boukenka
Copy link
Contributor Author

boukenka commented May 1, 2025

Thanks @Anu6is. All checks have passed. 😃

@boukenka boukenka marked this pull request as draft May 1, 2025 08:08
@boukenka boukenka marked this pull request as ready for review May 1, 2025 08:08
@boukenka boukenka changed the title MudCheckBox : Change disabled text color MudCheckBox: Change disabled text color May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielchalmers danielchalmers Awaiting requested review from danielchalmers

@Garderoben Garderoben Awaiting requested review from Garderoben

Assignees
No one assigned
Labels
enhancement New feature or request PR: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boukenka