Unit Tests: Fix selecting hidden dates #11265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thanks @Anu6is :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11265 +/- ##
=======================================
Coverage 91.09% 91.10%
=======================================
Files 439 439
Lines 14235 14235
Branches 2759 2759
=======================================
+ Hits 12968 12969 +1
Misses 638 638
+ Partials 629 628 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ScarletKuro
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the first day of a given month starts on any day other than a Sunday, the calendar will contain hidden dates from the end of the previous month. Some test cases select the first occurrence of a date by number. Sometimes that date may be a hidden date from the previous month. Unit tests should filter out these dates when selecting a date.
Fixes failing tests in the following PRs:
How Has This Been Tested?
Retried failing test
Checklist
dev).