Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DataGrid - GroupingByOrder / StyleFix / Expansion StateHasChanged #11302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

DataGrid - GroupingByOrder / StyleFix / Expansion StateHasChanged #11302

wants to merge 7 commits into from

Conversation

versile2
Copy link
Contributor

@versile2 versile2 commented May 6, 2025

Description

Moved Expansion logic to MudDataGrid since it needs to refresh grid and the logic needed to set the _groupExpansionsDict is in the grid.
Setup a proper GroupByOrder when items are grouped manually.
Fixed a class mismatch on Group Expander Icon
Resolves #11290
Resolves #11300

How Has This Been Tested?

Updated two unit tests, one for my changes, and one was not testing the right thing highlighted by my changes
Added a unit test for GroupByOrder

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 6, 2025
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.13%. Comparing base (bbb7333) to head (53935e7).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/MudBlazor/Components/DataGrid/Column.razor.cs 0.00% 0 Missing and 3 partials ⚠️
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #11302      +/-   ##
==========================================
- Coverage   91.14%   91.13%   -0.02%     
==========================================
  Files         439      439              
  Lines       14238    14241       +3     
  Branches     2759     2760       +1     
==========================================
+ Hits        12977    12978       +1     
+ Misses        635      634       -1     
- Partials      626      629       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something does not work as intended/expected PR: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MudDataGrid MultiLevel Grouping Order Can't be Changed MudDataGrid issues since 8.6
1 participant
@versile2