DataGrid: GroupingByOrder / Style Fix / Expansion StateHasChanged #11302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to ensure comparison is good for group Key.
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (82.35%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #11302 +/- ##
==========================================
- Coverage 91.14% 91.11% -0.03%
==========================================
Files 439 465 +26
Lines 14238 14406 +168
Branches 2759 2787 +28
==========================================
+ Hits 12977 13126 +149
- Misses 635 642 +7
- Partials 626 638 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ved for visual feedback
ScarletKuro
reviewed
May 20, 2025
|
|
Is this good to go now? |
|
Yes |
ScarletKuro
approved these changes
May 21, 2025
This was referenced Aug 1, 2025
This was referenced Aug 5, 2025
This was referenced Aug 14, 2025
This was referenced Aug 25, 2025
This was referenced Sep 3, 2025
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved Expansion logic to MudDataGrid since it needs to refresh grid and the logic needed to set the _groupExpansionsDict is in the grid.
Setup a proper GroupByOrder when items are grouped manually.
Fixed a class mismatch on Group Expander Icon
Resolves #11290
Resolves #11300
How Has This Been Tested?
Updated two unit tests, one for my changes, and one was not testing the right thing highlighted by my changes
Added a unit test for GroupByOrder
Type of Changes
Checklist
dev).