Confirm spacing fixes already applied in welford.cu#1947
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Merged
Copilot
AI
changed the title
[WIP] Remove compat.h and replace DATA_PTR
Confirm spacing fixes already applied in welford.cu
Nov 7, 2025
Collaborator
|
Thank you for verifying all the comments are already addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review comments on PR #1942 flagged missing spaces in ternary operators at lines 1261 and 1282 in
csrc/welford.cu. These issues were already fixed in commit 9d15f6e.Changes:
:NULL→: NULLAll ternary operators now follow consistent spacing:
condition ? value : NULL✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.