Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(core): Added css class for styling dialog nested elements #10605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Aug 10, 2024

PR Checklist

What is the current behavior?

Ever since #10201, Dialog buttons, labels, and inputs are affected by global scope CSS. That brings the drawback of not being able to style the dialog specifically. One good example example, some apps ended up with light-colored text not being distinct in light-mode Dialogs because of how these apps were styled in global scope.

What is the new behavior?

Added ns-dialog-item css class to style nested dialog views.

Sample:

Label {
  color: #fff;
}

Label.ns-dialog-item {
  color: #000;
}

@cla-bot cla-bot bot added the cla: yes label Aug 10, 2024
@NathanWalker NathanWalker merged commit 6104b5b into NativeScript:main Aug 23, 2024
4 checks passed
@dyazincahya
Copy link

dyazincahya commented Oct 24, 2024

please also add how to use it in the documentation page

@CatchABus
Copy link
Contributor Author

please also add how to use it in the documentation page

That's a good idea. Thanks for pointing out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants