fix(modal): persist modal through configuration changes #9533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update svelte config to use svelte-loader * handle null config * fix: worker support in .svelte files & update snapshots * fix after merge Co-authored-by: halfnelson <[email protected]> Co-authored-by: Igor Randjelovic <[email protected]>
Allows running older projects
NathanWalker
requested changes
Sep 4, 2021
NathanWalker
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When you change the device configuration, the activities will be destroyed and the app will recreate them. This includes dialogs.
Currently, doing this will crash because we're clearing the dialog's options and dismissing the modal.
What is the new behavior?
We no longer dismiss the modal or clear it's config if it's happening during a configuration change.
Also, we cache the activity because
this.getActivity()can return null if the modal has been detached from the activity.