-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: clipsToBounds support #9539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…eScript into release/8.1.0
…' on fwd navigation (#8791) Changes the behavior of android fragment transactions to use `add` instead of `replace` on forward navigation. BREAKING CHANGE: Changes the internal behavior of Android navigation: * while navigating forward, the page navigated from is not unloaded anymore * events order is changed in the sense that now `unloaded` happens after `navigatedFrom` instead of before There are multiple plus sides to this: * no more black views on navigation when using opengl (maps, ...) * navigation is faster, especially the navigation back! No longer need to recreate the page anymore. Navigation forward also gets faster as we no longer unload the previous page * navigatedFrom event happens faster * this the default behavior used by most of the android native apps
This reverts commit 4c547bb.
Fixed the incorrectly applied short form of "transform: translate" style property. closes #5202
It was unnecessary to make multiple calls requestLayout inside initNativeView (properties set)
* performance improvements around border handling BREAKING CHANGE: * if you have broder-radius or clip-path, it will clip by default
This feature needs some more work & will be included in a future version
* feat: Frame replacePage by entry * feat(webpack): improved svelte HMR (#9497) * update svelte config to use svelte-loader * handle null config * fix: worker support in .svelte files & update snapshots * fix after merge Co-authored-by: halfnelson <[email protected]> Co-authored-by: Igor Randjelovic <[email protected]> * feat(webpack): use svelte-loader and fallback to svelte-loader-hot Allows running older projects * feat: allow overwriting replacePage transition Co-authored-by: farfromrefuge <[email protected]> Co-authored-by: halfnelson <[email protected]>
WIP - needs more work
583d84a
to
a5b1a18
Compare
@dimitrisrk you cant use |
I'm leaving notes as a feedback regarding this feature. From my experience at trying to get rid of clipping in android, I have concluded that setting clipping to false for scrollable views will let their children overflow during scrolling. |
I was wondering why this PR had flaws and It seems Outline has its own limitations.
https://developer.android.com/reference/android/graphics/Outline#canClip() It seems that |
@CatchABus indeed this is why i am using clipping path (if i remember correctly) |
@farfromrefug here's a branch with the clipsToBounds changes - we had to revert them in the release branch here: 7785405
We've seen some issues with this change, some with the borders and some with boxShadow, so we'd like to step back a bit and make sure everything works as expected before we release this.