Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Language.Nix: improve and test Identifier handling #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 15, 2025
Merged

Language.Nix: improve and test Identifier handling #669

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
644be5e
Language.Nix.Identifier: Identifiers can never contain NUL bytes
sternenseemann Sep 12, 2025
0c58f0c
Language.Nix.Identifier: move props for ident into test suite
sternenseemann Sep 12, 2025
bccd73e
Language.Nix.Identifier: move parseM properties into test suite
sternenseemann Sep 12, 2025
e124dab
language-nix/test: avoid NUL bytes
sternenseemann Sep 12, 2025
1b257dd
language-nix/test: report how many tested identifiers need quoting
sternenseemann Sep 12, 2025
eb6475f
Language.Nix.Identifier: generate more simple identifiers
sternenseemann Sep 12, 2025
d3bfb90
language-nix: exclude unused Paths_ module
sternenseemann Sep 12, 2025
1c0287d
Language.Nix.Identifier: there is no Text class
sternenseemann Sep 12, 2025
5ee5f4c
Language.Nix.Identifier: add parseM examples
sternenseemann Sep 12, 2025
6417872
Language.Nix.Identifier: quote Identifiers that are Nix keywords
sternenseemann Sep 12, 2025
17586e3
hackage2nix: use Identifier for bindings in hackage-packages.nix
sternenseemann Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
language-nix/test: report how many tested identifiers need quoting 
Currently this is practically > 95% which isn't great. Presumably, the
examples for simple identifiers are very short as well.
  • Loading branch information
@sternenseemann
sternenseemann committed Sep 12, 2025
commit 1b257dd0bee74c3f5aab5dfad8ca3426e2b30d9b
8 changes: 6 additions & 2 deletions language-nix/test/hspec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,14 @@ main = hspec $ do

describe "HasParser Identifier" $ do
it "can parse the result of prettyShow" $
property $ \i -> parseM "Identifier" (prettyShow i) == Just (i :: Identifier)
identProperty $ \i -> parseM "Identifier" (prettyShow i) == Just (i :: Identifier)
it "can parse the result of quote" $
stringIdentProperty $ \str -> parseM "Identifier" (quote str) == Just (ident # str)

stringIdentProperty :: (String -> Bool) -> Property
stringIdentProperty p = property $ \s ->
'\0' `notElem` s ==> p s
'\0' `notElem` s ==> classify (needsQuoting s) "need quoting" $ p s

identProperty :: (Identifier -> Bool) -> Property
identProperty p = property $ \i ->
classify (needsQuoting (from ident # i)) "need quoting" $ p i